Skip to content

Commit 89b0cae

Browse files
committed
CI: Remove parallelism
1 parent 4a5e0ee commit 89b0cae

3 files changed

Lines changed: 82 additions & 24 deletions

File tree

.github/workflows/playwright.yml

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -246,6 +246,26 @@ jobs:
246246
BASE_URL: http://localhost
247247
run: yarn test:playwright:seed-settings
248248

249+
# NOTE (2026-08-23): a fifth seed step ("Seed course
250+
# subscriptions", subscribing acostea/fapple to TEMP) briefly lived
251+
# here and was REMOVED again on purpose. It is redundant now that
252+
# playwright.config.ts pins `workers: 1`: file order is fixed, and
253+
# course_user_registration.feature sorts before toolGroup.feature,
254+
# so the subscriptions exist by the time anything needs them.
255+
#
256+
# It was also actively harmful. Hoisting those scenarios out of
257+
# their own file broke that file's internal narrative (it
258+
# subscribes amann, unsubscribes him, then re-subscribes him as a
259+
# fixture): with amann pre-subscribed, its first scenario had
260+
# nobody left to select, because subscribe_user.php's picker
261+
# excludes already-subscribed users. And it could never have fixed
262+
# the failures it targeted anyway — a seed guarantees a fixture
263+
# exists at the START, but course TEMP's user list is written by
264+
# four different feature files, so under parallel execution another
265+
# file could still unsubscribe fapple mid-run (measured: it did).
266+
# Ordering, not more seeding, is the actual fix. See
267+
# playwright.config.ts's `workers: 1` comment for the full history.
268+
249269
- name: Playwright tests
250270
env:
251271
BASE_URL: http://localhost

0 commit comments

Comments
 (0)