Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lagging Behind control #25

Open
yuroyami opened this issue Jul 12, 2022 · 2 comments
Open

Lagging Behind control #25

yuroyami opened this issue Jul 12, 2022 · 2 comments
Assignees
Labels
feature port Porting a feature from the PC version (Mimicking functionality)

Comments

@yuroyami
Copy link
Owner

ExoPlayer does not provide a good set of methods or interfaces to control videos' playback speed. However, a way to control speed should be implemented in order to port the following settings:

When the main user lags behind:

  • Checkable option: Fast-forward when lagging behind (on by default on Desktop).
  • Checkable option: Don't slow down or rewind others when lagging behind (off on Desktop, and is still experimental).

When others lag behind:

  • Checkable option: Slow down on minor desync (On by default on Desktop)
  • Checkable option: Rewind on major desync (Already implemented on Android, even rewind threshold is adjustable, but there has to be an option to disable it)
@yuroyami yuroyami added the feature port Porting a feature from the PC version (Mimicking functionality) label Jul 12, 2022
@yuroyami yuroyami self-assigned this Jul 12, 2022
@RaXorX
Copy link

RaXorX commented Dec 30, 2024

Has there been progress on this?

Edit: Asking because the custom skip option doesn't work well when the default behaviour of syncplay keeps rewinding the time. It interferes with it heavily especially if playing a network file. I presume that it'd be a lot better to enforce the custom skip to send it as the current playing time to other clients.

@yuroyami
Copy link
Owner Author

@RaXorX I haven’t tackled this yet as it would complicate the syncplay protocol and require adding support to every player. Pull requests are always welcome, but I imagine something this big would be quite a job. I might get around to it when I’m back working on this project. In the meantime, could you explain exactly what issue you’re running into? By custom skip button, do you mean the one that lets you jump forward by a user-defined duration? If so– and correct me if I am wrong, as you jump forward, it pulls you back to the original point of time because the leap is too large. Right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature port Porting a feature from the PC version (Mimicking functionality)
Projects
None yet
Development

No branches or pull requests

2 participants