Image pull secret not added for setup credentials job

[johnny-gossick]

The setup credentials job is missing the image pool secret set here.

If the user sets a custom image repository here and their registry requires authentication, the setup credentials job will throw an image ImagePullBackOff and not be able to start.

[dbblackdiamond]

I am running into the same issue. The reason for this is that the template for the setup credentials job doesn't include any key inheriting its value from the values.yaml file. It could be fixed by adding a pullSecretName to spec.template.spec with a value of {{ .Values.Image.pullSecretName }}. This way, the pullSecretName defined in the values.yaml file get passed all the way to the setup credential job.

I can create a PR for this if there is consensus that it is the best way forward.