Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French places not editiable due to missing community value #837

Open
Tracked by #835
lgontard opened this issue Jan 22, 2025 · 5 comments · May be fixed by #835
Open
Tracked by #835

French places not editiable due to missing community value #837

lgontard opened this issue Jan 22, 2025 · 5 comments · May be fixed by #835

Comments

@lgontard
Copy link
Collaborator

lgontard commented Jan 22, 2025

As mentioned on other Places ticket, without a community value, the translated page cannot be published by editors.

As a workaround, making the field translatable seems to allow the page to be editable again.

Originally reported as: On the Fre side of the Places page, the community field is missing

Image Image
@leeomara
Copy link
Member

leeomara commented Feb 4, 2025

I don't understand the purpose of translating the field for selecting Community. What am I missing?

It's not as if the French record will have different Community value than the English. The label of the community maybe could be translated (e.g. "Carcross and Tagish" in English, "Carcross et Tagish" in French), but the fact a given Places record is associated with that community doesn't change depending on the language.

In fact, I'm not sure why a number of Places fields are translatable. What is the purpose of translating...

  • Region
  • Postal code
  • GPS coordinates
  • Map pin
  • Department

@leeomara leeomara linked a pull request Feb 4, 2025 that will close this issue
39 tasks
@w3creatives
Copy link
Collaborator

@leeomara Should we then disable the following fields on the French side?

  1. Community
  2. Region
  3. Postal code
  4. GPS coordinates
  5. Map pin
  6. Department

@lgontard
Copy link
Collaborator Author

lgontard commented Feb 5, 2025

It's not to translate, but as mentioned on other Places ticket, without editorial team and dept selected, the page cannot be published by editors. On the published French side, the community field is missing. I did a search by community in Places (Fre) and it seems like even when community is not on the Fre side the places page shows up in results. As long as not having community doesn't affect publishing for publishers or finding in the search then we don't need this field on the Fre side.

@leeomara
Copy link
Member

leeomara commented Mar 5, 2025

I'll update the title to clarify that we don't actually want the fields to be translatable, but for some cases (maybe migrated data that is missing those values?), those fields not being translatable means the translations are not editable by certain roles.

@leeomara leeomara changed the title On Fre side Places: missing community field French places not editiable due to missing community value Mar 5, 2025
@leeomara
Copy link
Member

leeomara commented Mar 5, 2025

In UAT, Places now exposes the Community fields as translatable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Intake
Development

Successfully merging a pull request may close this issue.

3 participants