Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing Campground in French leads to "encountered unexpected error" #831

Open
lgontard opened this issue Jan 15, 2025 · 7 comments · May be fixed by #835
Open

Editing Campground in French leads to "encountered unexpected error" #831

lgontard opened this issue Jan 15, 2025 · 7 comments · May be fixed by #835
Assignees
Labels
2025-pending-reply audience: external Public users, not logged in audience: internal For logged in site users, writers, editors, admins Campground and Recreation french priority: high

Comments

@lgontard
Copy link
Collaborator

lgontard commented Jan 15, 2025

FernchTranslation reports that when they try to edit campground page, they get the Unexpected error message. On the French side, the editorial team and department dropdown fields are missing. They are unable to update page to match Eng side affecting UX.

https://yukon.ca/fr/plein-air-faune-et-flore/camping/site/camping-kusawa-lake

Suspect that if these fields were on the French side of this content type that French would be able to edit and publish.

@lgontard lgontard added Campground and Recreation priority: high french audience: internal For logged in site users, writers, editors, admins audience: external Public users, not logged in labels Jan 15, 2025
This was referenced Jan 17, 2025
@w3creatives w3creatives self-assigned this Jan 19, 2025
@leeomara leeomara linked a pull request Feb 4, 2025 that will close this issue
39 tasks
@leeomara
Copy link
Member

leeomara commented Feb 8, 2025

After deploying #835 to UAT, I am still unable to edit certain records, like the Camping Kusawa Lake referenced in the original report.

e.g. https://yukon.cms-uat.yukon.ca/fr/node/1676/edit

Error:

Message d'erreur

1 error has been found: [Authored by]

Note: this was tested using a user who had the Translator role, and no admin roles.

@leeomara leeomara removed their assignment Feb 8, 2025
@leeomara leeomara moved this from Intake to To do in Yukon.ca Phase G Feb 8, 2025
@leeomara leeomara changed the title Unexpected error message French side Campground Editing Campground in French leads to "Unexpected error" Feb 11, 2025
@leeomara leeomara changed the title Editing Campground in French leads to "Unexpected error" Editing Campground in French leads to "encountered unexpected error" Feb 11, 2025
@w3creatives
Copy link
Collaborator

w3creatives commented Feb 13, 2025

User mike is blocked that's why we can't reference that user. Can you try changing the user status temporarily to see it this fixes the issue?

Image
Image

@lgontard
Copy link
Collaborator Author

lgontard commented Mar 5, 2025

https://yukon.ca/fr/plein-air-faune-et-flore/camping/site/camping-kusawa-lake I was able to edit and publish the page. I will ask FrenchTranslation to test. The dept and editorial team fields are not on the back end of the Fre side, so not having those fields there is not an issue.

@leeomara
Copy link
Member

leeomara commented Mar 5, 2025

The dept and editorial team fields are not on the back end of the Fre side

I worry about statements like this, because I fear that someone will see that and thing "the fix is to show those fields in French". Not all fields need to be translated. If the French and English version of a thing have the same meaning or value for a thing/field, or if that thing is itself already translated, they likely do not need to be separately editable in the French translation.

@lgontard
Copy link
Collaborator Author

lgontard commented Mar 5, 2025

As I recall on other content types those fields exist on the Fre side but were unselected. After ad admin updated those fields FrenchTranslation was able to edit and publish the page. Updated my comment to alleviate your worries;)

@lgontard lgontard closed this as completed Mar 5, 2025
@github-project-automation github-project-automation bot moved this from To do to Fixed in Yukon.ca Phase G Mar 5, 2025
@leeomara
Copy link
Member

leeomara commented Mar 5, 2025

On UAT, testing using an account with the Editor and Translator roles, editing a campground in French now exposes the Yukon Editorial Team and Department fields.

For the test case originally referenced, Kusawa (https://yukon.cms-uat.yukon.ca/fr/node/1676/edit), it shows the Yukon Editorial Team as empty, which would otherwise have caused a crash.

Re-opening this, as in prod, those fields are still not visible.

Slightly moot, as @lgontard recently edited all records as an admin to set the Yukon Editorial Team and Department values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2025-pending-reply audience: external Public users, not logged in audience: internal For logged in site users, writers, editors, admins Campground and Recreation french priority: high
Projects
Status: Review
Development

Successfully merging a pull request may close this issue.

3 participants