Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling, DEL, streaming #55

Open
01mf02 opened this issue Aug 14, 2024 · 1 comment
Open

Scrolling, DEL, streaming #55

01mf02 opened this issue Aug 14, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@01mf02
Copy link

01mf02 commented Aug 14, 2024

Thanks for this cool project, and I'm happy that you're using jaq for it. :)

When holding the DOWN key to scroll down a list of values, the visible list does not follow the currently selected value. That means that when my terminal is H characters high, I can never see anything else than the first H values. I would have expected the currently selected value to be always visible on the screen.

Furthermore, trying to delete the character after the current one in the query with the DEL key does not have any impact. On the other hand, the backspace key works as expected.

Finally, I tried the query 0 | recurse(.+1), which yields an infinite stream of natural numbers. However, as soon as I typed the final ")", jnv froze (could not terminate with CTRL-C / CTRL-D) and after some time, my memory was exhausted, forcing me to restart my machine. o_O It would be cool if jnv could load output values in the background, thus remaining always responsive.

I'm using xfce4-terminal.

@ynqa ynqa added the bug Something isn't working label Oct 31, 2024
@ynqa
Copy link
Owner

ynqa commented Oct 31, 2024

I apologize for the delayed response as I had been away from development for a while.

@01mf02 Thank you again for posting the issue. I am honored to have caught the attention of the creator of jaq :) Owing to jaq, I was free from the installation struggles, as seen in #24.

When holding the DOWN key to scroll down a list of values, the visible list does not follow the currently selected value.

There was a related regression in the library used to render JSON and similar content. This issue has now been resolved (ynqa/promkit#32), and I believe it was fixed in jnv v0.4.1. Please let me know if your recognize differs.

Furthermore, trying to delete the character after the current one in the query with the DEL key does not have any impact. On the other hand, the backspace key works as expected.

This may require further investigation into the behavior of crossterm.

I tried the query 0 | recurse(.+1), which yields an infinite stream of natural numbers. However, as soon as I typed the final “)”, jnv froze (could not terminate with CTRL-C / CTRL-D).

This seems to occur because jnv currently processes everything synchronously. I will verify this further in my environment and consider next steps accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants