Skip to content

Commit 3ca20dc

Browse files
committed
Fix mbean not found issue
1 parent 3886427 commit 3ca20dc

File tree

2 files changed

+15
-11
lines changed

2 files changed

+15
-11
lines changed

src/java/org/apache/cassandra/db/compression/CompressionDictionaryManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ private void unregisterMbean()
316316
if (mbeanRegistered)
317317
{
318318
MBeanWrapper.instance.unregisterMBean(mbeanName(keyspaceName, tableName), OnException.IGNORE);
319-
mbeanRegistered = true;
319+
mbeanRegistered = false;
320320
}
321321
}
322322

src/java/org/apache/cassandra/tools/nodetool/TrainCompressionDictionary.java

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ public void execute(NodeProbe probe)
6161
{
6262
TrainingState trainingState = probe.getCompressionDictionaryTrainingState(keyspace, table);
6363
TrainingStatus status = trainingState.getStatus();
64+
displayProgress(trainingState, startTime, out, status);
6465
if (TrainingStatus.COMPLETED == status)
6566
{
6667
out.printf("%nTraining completed successfully for %s.%s%n", keyspace, table);
@@ -84,16 +85,7 @@ else if (TrainingStatus.FAILED == status)
8485
System.exit(1);
8586
}
8687

87-
// Display meaningful statistics
88-
long sampleCount = trainingState.getSampleCount();
89-
long totalSampleSize = trainingState.getTotalSampleSize();
90-
long elapsedSeconds = (Clock.Global.currentTimeMillis() - startTime) / 1000;
91-
double sampleSizeMB = totalSampleSize / (1024.0 * 1024.0);
92-
93-
out.printf("\rStatus: %s | Samples: %d | Size: %.2f MiB | Elapsed: %ds",
94-
status, sampleCount, sampleSizeMB, elapsedSeconds);
95-
96-
Uninterruptibles.sleepUninterruptibly(2, TimeUnit.SECONDS);
88+
Uninterruptibles.sleepUninterruptibly(1, TimeUnit.SECONDS);
9789
}
9890

9991
err.printf("%nTraining did not complete within expected timeframe (10 minutes).%n");
@@ -105,4 +97,16 @@ else if (TrainingStatus.FAILED == status)
10597
System.exit(1);
10698
}
10799
}
100+
101+
private static void displayProgress(TrainingState trainingState, long startTime, PrintStream out, TrainingStatus status)
102+
{
103+
// Display meaningful statistics
104+
long sampleCount = trainingState.getSampleCount();
105+
long totalSampleSize = trainingState.getTotalSampleSize();
106+
long elapsedSeconds = (Clock.Global.currentTimeMillis() - startTime) / 1000;
107+
double sampleSizeMB = totalSampleSize / (1024.0 * 1024.0);
108+
109+
out.printf("\rStatus: %s | Samples: %d | Size: %.2f MiB | Elapsed: %ds",
110+
status, sampleCount, sampleSizeMB, elapsedSeconds);
111+
}
108112
}

0 commit comments

Comments
 (0)