From 8ab2ea4453da17f31735946630885268034f4727 Mon Sep 17 00:00:00 2001 From: August Skare Date: Fri, 29 Jul 2016 13:25:18 +0200 Subject: [PATCH 1/4] added support for manifest file --- tasks/filerev.js | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/tasks/filerev.js b/tasks/filerev.js index 9b94ab7..a94aa0c 100644 --- a/tasks/filerev.js +++ b/tasks/filerev.js @@ -15,6 +15,20 @@ module.exports = function (grunt) { length: 8 }); + if (options.manifestFile) { + if (grunt.file.isFile(options.manifestFile)) { + var manifest = grunt.file.readJSON(options.manifestFile); + for (var file in manifest) { + if (manifest.hasOwnProperty(file) && !filerev.summary[file]) { + filerev.summary[file] = manifest[file]; + } + } + grunt.verbose.writeln(chalk.green('✔ ') + 'Files from ' + options.manifestFile + ' are' + chalk.gray(' added ') + 'to summary.'); + } else { + grunt.fail.warn('Could not find manifest feil ' + options.manifestFile); + } + } + eachAsync(this.files, function (el, i, next) { var move = true; From 01eb4f12791e7c9ab25a83f4cd9b745255e46501 Mon Sep 17 00:00:00 2001 From: August Skare Date: Fri, 29 Jul 2016 13:32:55 +0200 Subject: [PATCH 2/4] added desc in readme --- README.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/README.md b/README.md index 4de79f6..e2aa256 100644 --- a/README.md +++ b/README.md @@ -92,6 +92,12 @@ filerev: { } ``` +### Manifest file + +Type: `file` + +JSON file to add additional files to `grunt.filerev.summary`. Useful for hash generated fils other tools (for example WebPack). + #### Summary The task keeps track of all files created and its sources in a summary that is From 8d0a5035456b1acc53c0ca3498148114ffa8ee35 Mon Sep 17 00:00:00 2001 From: August Skare Date: Fri, 29 Jul 2016 13:33:03 +0200 Subject: [PATCH 3/4] fix for passing tests --- tasks/filerev.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tasks/filerev.js b/tasks/filerev.js index a94aa0c..b0caa8a 100644 --- a/tasks/filerev.js +++ b/tasks/filerev.js @@ -19,7 +19,7 @@ module.exports = function (grunt) { if (grunt.file.isFile(options.manifestFile)) { var manifest = grunt.file.readJSON(options.manifestFile); for (var file in manifest) { - if (manifest.hasOwnProperty(file) && !filerev.summary[file]) { + if (!filerev.summary[file]) { filerev.summary[file] = manifest[file]; } } From 35a2e9a0f05011c894f4097811db8077a58b920b Mon Sep 17 00:00:00 2001 From: August Skare Date: Fri, 29 Jul 2016 13:38:12 +0200 Subject: [PATCH 4/4] fixed typo in readme --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index e2aa256..9d785ab 100644 --- a/README.md +++ b/README.md @@ -96,7 +96,7 @@ filerev: { Type: `file` -JSON file to add additional files to `grunt.filerev.summary`. Useful for hash generated fils other tools (for example WebPack). +JSON file to add additional files to `grunt.filerev.summary`. Useful for hash generated fils from other tools (for example WebPack). #### Summary