Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--skip-install not working #292

Open
springcomp opened this issue Dec 31, 2021 · 3 comments
Open

--skip-install not working #292

springcomp opened this issue Dec 31, 2021 · 3 comments

Comments

@springcomp
Copy link

springcomp commented Dec 31, 2021

I’m creating my own generator and compose with this generator-node while trying to skip installing dependencies.
This used to work with version 4.2.0 however, it no longer does with a more recent 5.x version.

	public async default() {
		this.composeWith(require.resolve('generator-node/generators/app'), {
			boilerplate: false,
			name: this.options.name,
			projectRoot: 'generators',
			skipInstall: this.options["skip-install"],
		});
	}
@JoshuaKGoldberg
Copy link

👋 @springcomp I know it's been a while, but from yeoman/yeoman#1779 we're rebooting maintenance here. Is this issue still something you're interested in resolving?

If so, could you please post a full reproduction (https://antfu.me/posts/why-reproductions-are-required)? We'll need to be able to look at and run your code in order to help. Thanks! 🎩

@springcomp
Copy link
Author

Hello @JoshuaKGoldberg yes I’m very much interested in a proper solution for this issue.
I’ll try and come up with a small repro case and will come back to you here.

@springcomp
Copy link
Author

Hey @JoshuaKGoldberg,

The snippet in the OP is coming out of my custom TypeScript generator.
This version is published as v0.8.0.
I can attest that it worked at the time with the following conditions:

  • NodeJS 12.22.12
  • Yo version 4.0.0

I will update this post to narrow down the versions after which it stopped working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants