Changed encoding/decoding error code

biosvs · biosvs · commit 7189d5847444 · 2024-03-15T11:35:13.000+01:00
Signed-off-by: Vitalii Levitskii &lt;vitalii@uber.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,7 +6,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 =======
 ## [Unreleased]
-- No changes yet.
+### Changed
+- errors: encoding/decoding (marshalling/unmarshalling) errors are now returned as CodeInternal (13) instead of CodeInvalidArgument (3).
 
 ## [1.72.1] - 2024-03-14
 - tchannel: Renamed caller-procedure header from `$rpc$-caller-procedure` to `rpc-caller-procedure`.
diff --git a/pkg/errors/client.go b/pkg/errors/client.go
@@ -71,5 +71,5 @@ func newClientEncodingError(req *transport.Request, isResponse bool, isHeader bo
 	parts = append(parts,
 		fmt.Sprintf("for procedure %q of service %q: %v",
 			req.Procedure, req.Service, err))
-	return yarpcerrors.Newf(yarpcerrors.CodeInvalidArgument, strings.Join(parts, " "))
+	return yarpcerrors.Newf(yarpcerrors.CodeInternal, strings.Join(parts, " "))
 }
diff --git a/pkg/errors/server.go b/pkg/errors/server.go
@@ -98,7 +98,7 @@ func newServerEncodingError(req *transport.Request, encodings []transport.Encodi
 	parts = append(parts,
 		fmt.Sprintf("for procedure %q of service %q from caller %q: %v",
 			req.Procedure, req.Service, req.Caller, err))
-	return yarpcerrors.Newf(yarpcerrors.CodeInvalidArgument, strings.Join(parts, " "))
+	return yarpcerrors.Newf(yarpcerrors.CodeInternal, strings.Join(parts, " "))
 }
 
 func newEncodingMismatchError(want []transport.Encoding, got transport.Encoding) error {

Original file line number	Diff line number	Diff line change
`@@ -71,5 +71,5 @@ func newClientEncodingError(req *transport.Request, isResponse bool, isHeader bo`
`71`	`71`	`parts = append(parts,`
`72`	`72`	`fmt.Sprintf("for procedure %q of service %q: %v",`
`73`	`73`	`req.Procedure, req.Service, err))`
`74`		`- return yarpcerrors.Newf(yarpcerrors.CodeInvalidArgument, strings.Join(parts, " "))`
	`74`	`+ return yarpcerrors.Newf(yarpcerrors.CodeInternal, strings.Join(parts, " "))`
`75`	`75`	`}`
Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ func newServerEncodingError(req *transport.Request, encodings []transport.Encodi`
`98`	`98`	`parts = append(parts,`
`99`	`99`	`fmt.Sprintf("for procedure %q of service %q from caller %q: %v",`
`100`	`100`	`req.Procedure, req.Service, req.Caller, err))`
`101`		`- return yarpcerrors.Newf(yarpcerrors.CodeInvalidArgument, strings.Join(parts, " "))`
	`101`	`+ return yarpcerrors.Newf(yarpcerrors.CodeInternal, strings.Join(parts, " "))`
`102`	`102`	`}`
`103`	`103`
`104`	`104`	`func newEncodingMismatchError(want []transport.Encoding, got transport.Encoding) error {`