Update to ember 3.22

Author: lukemelia

.eslintrc.js

@@ -20,9 +20,7 @@ module.exports = {
   env: {
     browser: true
   },
-  rules: {
-    'ember/no-jquery': 'error'
-  },
+  rules: {},
   overrides: [
     // node files
     {
@@ -49,9 +47,7 @@ module.exports = {
         node: true
       },
       plugins: ['node'],
-      rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, {
-        // add your custom rules and overrides for node files here
-      })
+      extends: ['plugin:node/recommended']
     }
   ]
 };

.travis.yml

@@ -5,7 +5,7 @@ node_js:
   # so that your addon works for all apps
   - "10"
 
-dist: trusty
+dist: xenial
 
 addons:
   chrome: stable
@@ -47,13 +47,17 @@ jobs:
 
     # we recommend new addons test the current and previous LTS
     # as well as latest stable release (bonus points to beta/canary)
-    - env: EMBER_TRY_SCENARIO=ember-lts-3.12
     - env: EMBER_TRY_SCENARIO=ember-lts-3.16
+    - env: EMBER_TRY_SCENARIO=ember-lts-3.20
     - env: EMBER_TRY_SCENARIO=ember-release
     - env: EMBER_TRY_SCENARIO=ember-beta
     - env: EMBER_TRY_SCENARIO=ember-canary
     - env: EMBER_TRY_SCENARIO=ember-default-with-jquery
     - env: EMBER_TRY_SCENARIO=ember-classic
 
+before_install:
+  - curl -o- -L https://yarnpkg.com/install.sh | bash
+  - export PATH=$HOME/.yarn/bin:$PATH
+
 script:
   - node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO

README.md

@@ -7,7 +7,7 @@
 Compatibility
 ------------------------------------------------------------------------------
 
-* Ember.js v3.12 or above
+* Ember.js v3.16 or above
 * Ember CLI v2.13 or above
 * Node.js v10 or above
 

addon/components/collection-scroll-view/index.js

@@ -1,6 +1,6 @@
 import Component from '@glimmer/component';
 import { reads } from 'macro-decorators';
-import { tracked } from '@glimmer/tracking';
+import { cached, tracked } from '@glimmer/tracking';
 import { action } from '@ember/object';
 import { next, schedule } from '@ember/runloop';
 
@@ -40,7 +40,6 @@ export default class CollectionScrollView extends Component {
   @tracked scrollTop = 0;
   @tracked clientWidth;
   @tracked clientHeight;
-  @tracked measuredClientSize;
   @tracked contentSize;
 
   @reads('headerDimensions.height', 0) headerHeight;
@@ -102,11 +101,23 @@ export default class CollectionScrollView extends Component {
 
   @action
   clientSizeChange(clientWidth, clientHeight) {
-    this.measuredClientSize = {
-      width: clientWidth,
-      height: clientHeight
-    };
-    // this._needsRevalidate();
+    next(() => {
+      if (!this.isDestroyed) {
+        this.clientWidth = clientWidth;
+        this.clientHeight = clientHeight;
+      }
+    })
+  }
+
+  @cached
+  get measuredClientSize() {
+    if (this.clientWidth && this.clientHeight) {
+      return {
+        width: this.clientWidth,
+        height: this.clientHeight
+      };
+    }
+    return null;
   }
 
   @action

config/ember-try.js

@@ -6,18 +6,18 @@ module.exports = async function() {
   return {
     scenarios: [
       {
-        name: 'ember-lts-3.12',
+        name: 'ember-lts-3.16',
         npm: {
           devDependencies: {
-            'ember-source': '~3.12.0'
+            'ember-source': '~3.16.0'
           }
         }
       },
       {
-        name: 'ember-lts-3.16',
+        name: 'ember-lts-3.20',
         npm: {
           devDependencies: {
-            'ember-source': '~3.16.0'
+            'ember-source': '~3.20.5'
           }
         }
       },
@@ -45,16 +45,6 @@ module.exports = async function() {
           }
         }
       },
-      // The default `.travis.yml` runs this scenario via `npm test`,
-      // not via `ember try`. It's still included here so that running
-      // `ember try:each` manually or from a customized CI config will run it
-      // along with all the other scenarios.
-      {
-        name: 'ember-default',
-        npm: {
-          devDependencies: {}
-        }
-      },
       {
         name: 'ember-default-with-jquery',
         env: {
@@ -64,7 +54,7 @@ module.exports = async function() {
         },
         npm: {
           devDependencies: {
-            '@ember/jquery': '^0.5.1'
+            '@ember/jquery': '^1.1.0'
           }
         }
       },

package.json

@@ -27,11 +27,12 @@
   },
   "dependencies": {
     "@ember/render-modifiers": "^1.0.2",
-    "@glimmer/tracking": "^1.0.0",
+    "@glimmer/tracking": "^1.0.2",
     "broccoli-stew": "^2.1.0",
-    "ember-auto-import": "^1.5.3",
-    "ember-cli-babel": "7.20.5",
-    "ember-cli-htmlbars": "^5.1.2",
+    "ember-auto-import": "^1.6.0",
+    "ember-cached-decorator-polyfill": "^0.1.0",
+    "ember-cli-babel": "7.22.1",
+    "ember-cli-htmlbars": "^5.3.1",
     "ember-composable-helpers": "^4.3.0",
     "ember-concurrency-decorators": "^2.0.0",
     "ember-concurrency": "^1.2.1",
@@ -48,39 +49,39 @@
   },
   "devDependencies": {
     "@babel/core": "^7.10.2",
-    "@ember/optional-features": "^1.3.0",
-    "@glimmer/component": "^1.0.0",
+    "@ember/optional-features": "^2.0.0",
+    "@glimmer/component": "^1.0.2",
     "babel-eslint": "^10.1.0",
     "broccoli-asset-rev": "^3.0.0",
-    "ember-cli": "~3.18.0",
+    "ember-cli": "~3.22.0",
     "ember-cli-dependency-checker": "^3.2.0",
     "ember-cli-deploy": "^1.0.2",
     "ember-cli-deploy-build": "^2.0.0",
     "ember-cli-deploy-git": "^1.3.3",
     "ember-cli-inject-live-reload": "^2.0.2",
     "ember-cli-sass": "^10.0.1",
     "ember-cli-sri": "^2.1.1",
-    "ember-cli-uglify": "^3.0.0",
+    "ember-cli-terser": "^4.0.0",
     "ember-collection": "1.0.0",
     "ember-decorators-polyfill": "^1.1.5",
     "ember-disable-prototype-extensions": "^1.1.3",
     "ember-export-application-global": "^2.0.1",
     "ember-load-initializers": "^2.1.1",
     "ember-maybe-import-regenerator": "^0.1.6",
     "ember-qunit": "^4.6.0",
-    "ember-resolver": "^8.0.0",
+    "ember-resolver": "^8.0.2",
     "ember-simulant-test-helpers": "^0.3.1",
-    "ember-source": "~3.18.0",
-    "ember-source-channel-url": "^2.0.1",
-    "ember-template-lint": "^2.6.0",
+    "ember-source": "~3.22.0",
+    "ember-source-channel-url": "^3.0.0",
+    "ember-template-lint": "^2.14.0",
     "ember-try": "^1.4.0",
-    "eslint": "^7.2.0",
-    "eslint-plugin-ember": "^8.4.0",
+    "eslint": "^7.11.0",
+    "eslint-plugin-ember": "^9.3.0",
     "eslint-plugin-node": "^11.1.0",
     "layout-bin-packer": "^1.2.0",
     "loader.js": "^4.7.0",
     "npm-run-all": "^4.1.5",
-    "qunit-dom": "^1.2.0",
+    "qunit-dom": "^1.5.0",
     "release-it": "^13.6.2",
     "release-it-lerna-changelog": "^2.3.0",
     "sass": "^1.26.8"

tests/dummy/app/app.js

@@ -1,7 +1,7 @@
 import Application from '@ember/application';
 import Resolver from 'ember-resolver';
 import loadInitializers from 'ember-load-initializers';
-import config from './config/environment';
+import config from 'dummy/config/environment';
 
 export default class App extends Application {
   modulePrefix = config.modulePrefix;

tests/dummy/app/router.js

@@ -1,5 +1,5 @@
 import EmberRouter from '@ember/routing/router';
-import config from './config/environment';
+import config from 'dummy/config/environment';
 
 export default class Router extends EmberRouter {
   location = config.locationType;

tests/dummy/config/ember-cli-update.json

@@ -3,7 +3,7 @@
   "packages": [
     {
       "name": "ember-cli",
-      "version": "3.18.0",
+      "version": "3.22.0",
       "blueprints": [
         {
           "name": "addon",

tests/dummy/config/targets.js

@@ -6,7 +6,7 @@ const browsers = [
   'last 1 Safari versions'
 ];
 
-const isCI = !!process.env.CI;
+const isCI = Boolean(process.env.CI);
 const isProduction = process.env.EMBER_ENV === 'production';
 
 if (isCI || isProduction) {

tests/test-helper.js

@@ -1,5 +1,5 @@
-import Application from '../app';
-import config from '../config/environment';
+import Application from 'dummy/app';
+import config from 'dummy/config/environment';
 import { setApplication } from '@ember/test-helpers';
 import { start } from 'ember-qunit';