Merge pull request #88 from yappbox/safe-tear-down

lukemelia · web-flow · commit d075c9318499 · 2023-12-15T11:05:36.000-05:00
Avoid error when tearing down component if scrollViewElement is not set
diff --git a/addon/components/scroll-view.js b/addon/components/scroll-view.js
@@ -293,7 +293,7 @@ class ScrollView extends Component {
       this.hammer.destroy();
       this.hammer = null;
     }
-    element.removeEventListener(
+    element?.removeEventListener(
       normalizeWheel.getEventType(),
       this._boundHandleWheel,
       false

Original file line number	Diff line number	Diff line change
`@@ -293,7 +293,7 @@ class ScrollView extends Component {`
`293`	`293`	`this.hammer.destroy();`
`294`	`294`	`this.hammer = null;`
`295`	`295`	`}`
`296`		`- element.removeEventListener(`
	`296`	`+ element?.removeEventListener(`
`297`	`297`	`normalizeWheel.getEventType(),`
`298`	`298`	`this._boundHandleWheel,`
`299`	`299`	`false`