Add guards to scrollToItem

lukemelia · lukemelia · commit 7c6566e7a814 · 2020-10-19T12:42:03.000+08:00
diff --git a/addon/components/collection-scroll-view/index.js b/addon/components/collection-scroll-view/index.js
@@ -137,5 +137,5 @@ function isChildComponent(component, candidateChildComponent) {
 }
 
 function isChildElement(element, candidateChildElement) {
-  return element.contains(candidateChildElement);
+  return  element && (candidateChildElement instanceof HTMLElement) && element.contains(candidateChildElement);
 }

Original file line number	Diff line number	Diff line change
`@@ -137,5 +137,5 @@ function isChildComponent(component, candidateChildComponent) {`
`137`	`137`	`}`
`138`	`138`
`139`	`139`	`function isChildElement(element, candidateChildElement) {`
`140`		`- return element.contains(candidateChildElement);`
	`140`	`+ return element && (candidateChildElement instanceof HTMLElement) && element.contains(candidateChildElement);`
`141`	`141`	`}`