fix(theme): review hardening — guard pref init, validate SET_SINGLE key, remove dead code

preference.vue: restore try/catch around addThemeStyle in onMounted so
a theme failure cannot block ASK_FOR_USER_PREFERENCE.

preferences.js: add typeof guard in SET_SINGLE_PREFERENCE to reject
unknown keys, matching the existing guard in SET_USER_PREFERENCE.

theme.js: delete unused ORIGINAL_THEME constant and getThemeCluster
function (zero callers across entire codebase).

Author: xronocode

src/renderer/src/pages/preference.vue

@@ -48,7 +48,9 @@ watch(theme, (newValue, oldValue) => {
 onMounted(() => {
   nextTick(() => {
     const state = window.marktext.initialState || DEFAULT_STYLE
-    addThemeStyle(state.theme)
+    try {
+      addThemeStyle(state.theme)
+    } catch (_) { /* theme failure must not block pref init */ }
     preferencesStore.ASK_FOR_USER_PREFERENCE()
   })
 })

src/renderer/src/store/preferences.js

@@ -174,6 +174,7 @@ export const usePreferencesStore = defineStore('preferences', {
     },
 
     async SET_SINGLE_PREFERENCE({ type, value }) {
+      if (typeof this[type] === 'undefined') return
       this[type] = value
 
       // Update i18n language if language preference changed

src/renderer/src/util/theme.js

@@ -43,7 +43,6 @@ import {
 } from './themeColor'
 import { isLinux } from './index'
 
-const ORIGINAL_THEME = '#409EFF'
 const patchTheme = (css) => {
   return `@media not print {\n${css}\n}`
 }
@@ -54,41 +53,6 @@ const getEmojiPickerPatch = () => {
     : ''
 }
 
-const getThemeCluster = (themeColor) => {
-  const tintColor = (color, tint) => {
-    let red = parseInt(color.slice(1, 3), 16)
-    let green = parseInt(color.slice(3, 5), 16)
-    let blue = parseInt(color.slice(5, 7), 16)
-    if (tint === 0) {
-      // when primary color is in its rgb space
-      return [red, green, blue].join(',')
-    } else {
-      red += Math.round(tint * (255 - red))
-      green += Math.round(tint * (255 - green))
-      blue += Math.round(tint * (255 - blue))
-      red = red.toString(16)
-      green = green.toString(16)
-      blue = blue.toString(16)
-      return `#${red}${green}${blue}`
-    }
-  }
-
-  const clusters = [
-    {
-      color: themeColor,
-      variable: 'var(--themeColor)'
-    }
-  ]
-  for (let i = 9; i >= 1; i--) {
-    clusters.push({
-      color: tintColor(themeColor, Number((i / 10).toFixed(2))),
-      variable: `var(--themeColor${10 - i}0)`
-    })
-  }
-
-  return clusters
-}
-
 export const addThemeStyle = (theme) => {
   const isCmRailscasts = railscastsThemes.includes(theme)
   const isCmOneDark = oneDarkThemes.includes(theme)