Remove skip dialog [release]

Author: crschnick

app/src/main/java/io/xpipe/app/hub/comp/StoreCreationDialog.java

@@ -149,15 +149,6 @@ private static void show(
         modal.show();
     }
 
-    private static boolean showInvalidConfirmAlert() {
-        var retry = new SimpleBooleanProperty();
-        var modal = ModalOverlay.of("confirmInvalidStoreTitle", AppDialog.dialogTextKey("confirmInvalidStoreContent"));
-        modal.addButton(new ModalButton("retry", () -> retry.set(true), true, false));
-        modal.addButton(new ModalButton("skip", null, true, true));
-        modal.showAndWait();
-        return !retry.get();
-    }
-
     private static ModalOverlay createModalOverlay(StoreCreationModel model) {
         var comp = new StoreCreationComp(model);
         comp.prefWidth(650);
@@ -210,12 +201,8 @@ private static ModalOverlay createModalOverlay(StoreCreationModel model) {
         modal.addButton(new ModalButton(
                         "skip",
                         () -> {
-                            if (!model.wasChanged() || showInvalidConfirmAlert()) {
-                                model.commit(false);
-                                modal.close();
-                            } else {
-                                model.finish();
-                            }
+                            model.commit(false);
+                            modal.close();
                         },
                         false,
                         false))

dist/changelog/18.7_incremental.md

@@ -4,3 +4,4 @@
 - Fix macOS Tahoe display name containing version twice
 - Fix inaccurate error message when a parent of a service did not support tunneling
 - Add setting to customize markdown notes template for connections
+- Remove confirm dialog when skipping connection validation to allow for faster connection creation