-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TabModel.title
will omit special characters like '&' because we run it through lodash's startCase
#3804
Comments
TabModel.title
will omit special characters like '&' because we run it through lodash's startCase
Sounds like we would benefit from an updated version of Line 175 in c6f7eb7
Could relocate out of this file and avoid the use of Although it looks to me like this only applies if you are not spec'ing a title and instead having the tab |
Were y'all thinking we would just not call startCase() if certain characters like I guess the former is at least a better, less surprising heuristic heuristic for generating a default display name -- although in either case the answer is really for the app to be explicit about what it wants. Not sure if this is a bug. @febbraiod -- did you just end up specing a title? |
Don and I discussed, and agreed that it was both strange for him to provide an id with special charachters, and easy for him to specify the title directly. Closing. |
This appears to happen by default when sourcing the title from the "id" provided in a config object through the TabContainerModel
The text was updated successfully, but these errors were encountered: