Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal messages should be constrained to viewport height #3792

Closed
amcclain opened this issue Sep 18, 2024 · 3 comments · Fixed by #3891
Closed

Modal messages should be constrained to viewport height #3792

amcclain opened this issue Sep 18, 2024 · 3 comments · Fixed by #3891
Assignees
@oodarluz
Labels
bug layouts ready

Comments

@amcclain
Copy link
Member

amcclain commented Sep 18, 2024 •
edited
Loading

...with internal scrolling of dialog body as needed.

Contrived test demonstrating how extra-long content might be (poorly) handled now:

Screenshot 2025-01-07 at 11 56 52 AM
@amcclain amcclain added the bug label Sep 18, 2024
@lbwexler
Copy link
Member

lbwexler commented Oct 3, 2024 •
edited
Loading

@oodarluz -- can you take a look at this one? Please have Tom review

@lbwexler
Copy link
Member

@oodarluz -- would like to get this knocked off, if possible

@oodarluz
Copy link
Contributor

I will spend time on it today

oodarluz added a commit that referenced this issue Jan 7, 2025
@oodarluz
Css to address message height in ticket #3792
bce9c2c
@oodarluz oodarluz mentioned this issue Jan 7, 2025
Merged
@oodarluz oodarluz linked a pull request Jan 7, 2025 that will close this issue
Constrain desktop message height to viewport #3891
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oodarluz oodarluz

Labels
bug layouts ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Constrain desktop message height to viewport xh/hoist-react
3 participants
@amcclain @lbwexler @oodarluz