Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support closure form of FetchService.autoGenCorrelationIds #3780

Closed
amcclain opened this issue Sep 9, 2024 · 0 comments · Fixed by #3882
Closed

Support closure form of FetchService.autoGenCorrelationIds #3780

amcclain opened this issue Sep 9, 2024 · 0 comments · Fixed by #3882

Comments

@amcclain
Copy link
Member

amcclain commented Sep 9, 2024

Currently spec'd as a boolean only, could be upgraded to Thunkable<boolean>, supporting a closure that would be passed FetchOptions for a given request to determine if an ID should be generated.

This could be used to e.g. only generate an ID for local/relative requests, avoiding doing so for CORS requests that don't support custom headers. Or for CORS requests to one API but not another. Or only for CORS requests - you get the idea. :)

@lbwexler lbwexler linked a pull request Dec 31, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant