Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to cancel/force rollback a migration #468

Open
danzika opened this issue Nov 18, 2024 · 4 comments
Open

Add support to cancel/force rollback a migration #468

danzika opened this issue Nov 18, 2024 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@danzika
Copy link

danzika commented Nov 18, 2024

In managed environments, like AWS RDS or GCP CloudSQL it is necessary to run the migration from a separate machine.
Then a network issue, ec2/vm failure or similar can happen causing the db connections to drop, failing the migration in turn.
This is likely to leave the migration in an inconsistent state, being unable to neither complete nor rollback, having to cleanup manually.
Please, add option abort/cancel/force rollback that wouldn't stop on consistency errors on only partially completed migration.

@danzika danzika changed the title Please add support to cancel a migration Add support to abort/cancel/force rollback/ a migration Nov 18, 2024
@danzika danzika changed the title Add support to abort/cancel/force rollback/ a migration Add support to cancel/force rollback a migration Nov 18, 2024
@exekias
Copy link
Member

exekias commented Nov 19, 2024

Thank you for opening this @danzika, do you have some logs of the errors you saw that you can share? It would be interesting to see those to diagnose the issue.

I agree overall it should be possible to recover from a failed start, either with the rollback command or something else

@exekias exekias added the bug Something isn't working label Nov 19, 2024
@danzika
Copy link
Author

danzika commented Nov 19, 2024

Actually I don't have logs for this. We just discussed this feature yesterday on a Meetup with @tsg.
So this is rather a feature request/enhancement than actual bug I have hit :)

@exekias exekias added enhancement New feature or request and removed bug Something isn't working labels Nov 19, 2024
@exekias
Copy link
Member

exekias commented Nov 19, 2024

Nice! thank you for opening. I believe as of today it's already possible to rollback a failed start. We make rollback operations idempotent so they can be run against intermediate states of start. Let's keep the issue open to double check this before closing it!

@exekias exekias added the documentation Improvements or additions to documentation label Nov 19, 2024
@danzika
Copy link
Author

danzika commented Nov 19, 2024

Amazing! Thanks for instant reaction. If already implemented it brings the tool one step closer to production readiness. Kudos

@ryanslade ryanslade self-assigned this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants