Make the NO_COLOR environment variable accept strings other than the “true” sings

Author: Songmu

logger/log.go

@@ -4,7 +4,6 @@ import (
 	"fmt"
 	"io"
 	"os"
-	"strings"
 
 	"github.com/motemen/go-colorine"
 )
@@ -51,16 +50,13 @@ var (
 )
 
 func init() {
-	SelectLogger()
+	selectLogger()
 }
 
-func SelectLogger() {
-	v := os.Getenv("NO_COLOR")
-
-	if strings.ToLower(v) == "true" {
+func selectLogger() {
+	if os.Getenv("NO_COLOR") != "" {
 		logger = loggerWithoutColor
 	}
-
 	SetOutput(os.Stderr)
 }
 

logger/log_test.go

@@ -8,7 +8,7 @@ import (
 func TestLog(t *testing.T) {
 	t.Run("with color", func(t *testing.T) {
 		t.Logf("NO_COLOR: %s", os.Getenv("NO_COLOR"))
-		SelectLogger()
+		selectLogger()
 		// info
 		Log("default", "should be green")
 		// verbose
@@ -25,7 +25,7 @@ func TestLog(t *testing.T) {
 	t.Run("without color", func(t *testing.T) {
 		t.Setenv("NO_COLOR", "true")
 		t.Logf("NO_COLOR: %s", os.Getenv("NO_COLOR"))
-		SelectLogger()
+		selectLogger()
 		// info
 		Log("default", "should be none")
 		// verbose