Skip to content

issue with module-info classes in v0.9.0 release #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pjfanning opened this issue May 18, 2023 · 3 comments
Closed

issue with module-info classes in v0.9.0 release #42

pjfanning opened this issue May 18, 2023 · 3 comments

Comments

@pjfanning
Copy link
Contributor

There are multiple module-info classes in the v0.9.0 jar. In v0.8.0, there was just the versions/9/module-info.class.

In v0.9.0, there are module-info.class fils in all the versions dirs.

This is causing FasterXML/jackson-core#1027

Would it be possible to get some background on the v0.9.0 changes, so that I can work out what to do with the jackson-core issues?

@wrandelshofer
Copy link
Owner

In prior releases, instead of being explicitly modular, we only had an Automatic-Module-Name in the META-INF/MANIFEST.MF file. Now we have proper module-info.class.

@wrandelshofer
Copy link
Owner

% unzip -v fastdoubleparser-0.9.0.jar | grep module-info
255 Defl:N 179 30% 04-30-2023 05:00 888d9237 META-INF/versions/11/module-info.class
255 Defl:N 179 30% 04-30-2023 05:00 a6603a18 META-INF/versions/17/module-info.class
328 Defl:N 191 42% 04-30-2023 05:00 8a1769af META-INF/versions/19/module-info.class

They should all be identical. So, including a module-info.class for versions/11 should have been sufficient. I don't know why the one for versions/19 is larger (?)

@pjfanning
Copy link
Contributor Author

Thanks, we probably just need to exclude these files from jackson-core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants