Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to using the VH-109 Radio #2885

Merged
merged 10 commits into from
Jan 1, 2025
Merged

Conversation

jasondaming
Copy link
Member

Fixes #2635

@jasondaming jasondaming marked this pull request as ready for review December 30, 2024 05:19
@jasondaming
Copy link
Member Author

I still have a little more work to do on radio-programming but I think this is at least ready for everyone to look at things.

@kiet

Copy link
Contributor

@Kevin-OConnor Kevin-OConnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jason. I've included a handful of comments but this looks most of the way there to me.

source/docs/controls-overviews/control-system-hardware.rst Outdated Show resolved Hide resolved
source/docs/zero-to-robot/step-3/radio-programming.rst Outdated Show resolved Hide resolved
source/docs/zero-to-robot/step-3/radio-programming.rst Outdated Show resolved Hide resolved
source/docs/zero-to-robot/step-3/radio-programming.rst Outdated Show resolved Hide resolved
source/docs/zero-to-robot/step-3/radio-programming.rst Outdated Show resolved Hide resolved
source/docs/zero-to-robot/step-3/radio-programming.rst Outdated Show resolved Hide resolved
Kevin-OConnor
Kevin-OConnor previously approved these changes Dec 30, 2024
Copy link
Contributor

@Kevin-OConnor Kevin-OConnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few of the checks are still running but other than that LGTM. Thanks!!

| +----------------+------------------------------+
| | Off | Booting Up |
+----------+----------------+------------------------------+
| 2.4G | Blinking (20Hz)| Battery detected, |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be solid rows for 2.4G and 6G

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand. I don't see any information on solid here: https://frc-radio.vivid-hosting.net/overview/led-status-indications

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used one, but I find it hard to believe that the only time the 2.4 or 6g LEDs are ever used is to say battery detected.

Copy link
Collaborator

@sciencewhiz sciencewhiz Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My interpretation of the vivid docs is that solid means the radio is enabled and off is radio is not enabled, and that blinking is a reason for it not to be solid.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the 2.4GHz when the dip switch is on I do see the light no matter if there is a connection or not, until the 6GHz is connected then it is shut off.

For 6GHz it appears to only go solid once connected.

I would really like to get confirmation of this

source/docs/software/support/support-resources.rst Outdated Show resolved Hide resolved
source/docs/software/frc-glossary.rst Outdated Show resolved Hide resolved

## Prerequisites

The FRC Radio Configuration Utility requires administrator privileges to configure the network settings on your machine. The program should request the necessary privileges automatically (may require a password if run from a non-administrator account), but if you are having trouble, try running it from an administrator account.
The recommended setup requires: 2 VH-109 radios, 1 VH-117 :term:`PoE` Wall Adapter, and 1 Radio Heatsink. Available [here](https://wcproducts.com/products/frc-radio).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like it could really use a picture to show how everything works together.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you talking about a picture like those here?
https://frc-radio.vivid-hosting.net/getting-started/usage/wiring-your-radio

Or here:
https://frc-radio.vivid-hosting.net/getting-started/usage/practicing-at-home#connectivity-diagram

I don't like the latter because it incorrectly labels the AP radio the robot radio and it shows an unnecessary unmanaged switch that the vast majority of teams don't need.

Copy link
Collaborator

@sciencewhiz sciencewhiz Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latter is what I was thinking of. Agree about the switch and labeling

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The video and some of the pictures still has the old radio. Should add some kind of call-out

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked Kevin last week about replacing them in the video or adding a note, nothing will likely happen in the short term but he will look into it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't expecting to be able to replace the video. Are you saying he'd look into adding a note in the docs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was saying a note in the video or removing the frames with the radio.

For the pictures we could just "photoshop" in the new radio.

I don't know how to get around that it is not recommended to mount the new radio face up buried in the chassis.

source/redirects.txt Outdated Show resolved Hide resolved
@sciencewhiz
Copy link
Collaborator

Should add something to the quick start for the new radio, since returning teams will need to set it up.

@sciencewhiz sciencewhiz merged commit a6ad120 into wpilibsuite:main Jan 1, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Documentation links for the Vivid Hosting Radios
3 participants