Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to using the VH-109 Radio #2885

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jasondaming
Copy link
Member

Fixes #2635

@jasondaming jasondaming marked this pull request as ready for review December 30, 2024 05:19
@jasondaming
Copy link
Member Author

I still have a little more work to do on radio-programming but I think this is at least ready for everyone to look at things.

@kiet

Copy link
Contributor

@Kevin-OConnor Kevin-OConnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jason. I've included a handful of comments but this looks most of the way there to me.

source/docs/controls-overviews/control-system-hardware.rst Outdated Show resolved Hide resolved
source/docs/zero-to-robot/step-3/radio-programming.rst Outdated Show resolved Hide resolved
source/docs/zero-to-robot/step-3/radio-programming.rst Outdated Show resolved Hide resolved
source/docs/zero-to-robot/step-3/radio-programming.rst Outdated Show resolved Hide resolved
source/docs/zero-to-robot/step-3/radio-programming.rst Outdated Show resolved Hide resolved
source/docs/zero-to-robot/step-3/radio-programming.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@Kevin-OConnor Kevin-OConnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few of the checks are still running but other than that LGTM. Thanks!!


.. image:: images/control-system-hardware/radio-power-module.png
:alt: REV Radio Power Module
.. image:: images/control-system-hardware/radio.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need an image credit added at the end

| +----------------+------------------------------+
| | Off | Booting Up |
+----------+----------------+------------------------------+
| 2.4G | Blinking (20Hz)| Battery detected, |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be solid rows for 2.4G and 6G

@@ -116,4 +116,4 @@ An issue with the ethernet cable on the robot is primarily indicated by the ping
.. image:: images/driver-station-log-viewer/radioreboot.png
:alt: The ping here shows the roboRIO and the radio as BAD.

A reboot of the robot radio is typically characterized by a loss of connection to the radio for ~40-45 seconds. In this example, the radio briefly lost power at 3:22:44, causing it to start rebooting. The event at 3:22:45 indicates that the ping to the radio failed. At 3:23:11, the DS regains communication with the roboRIO and the roboRIO indicates it has been up for 1272.775 seconds, ruling out a roboRIO reboot. Note that the network switch on the radio comes back up very quickly so a momentary power loss may not result in a "radio lost"/"radio seen" event pair. A longer disturbance may result in radio events being logged by the DS. In that case, the distinguishing factor which points towards a radio reboot is the ping status of the radio from the DS. If the radio resets, the radio will be unreachable. If the issue is a cabling or connection issue on the robot, the radio ping should remain "GOOD".
A reboot of the robot radio is typically characterized by a loss of connection to the radio for ~60 seconds. In this example, the radio briefly lost power at 3:22:44, causing it to start rebooting. The event at 3:22:45 indicates that the ping to the radio failed. At 3:23:11, the DS regains communication with the roboRIO and the roboRIO indicates it has been up for 1272.775 seconds, ruling out a roboRIO reboot. Note that the network switch on the radio comes back up very quickly so a momentary power loss may not result in a "radio lost"/"radio seen" event pair. A longer disturbance may result in radio events being logged by the DS. In that case, the distinguishing factor which points towards a radio reboot is the ping status of the radio from the DS. If the radio resets, the radio will be unreachable. If the issue is a cabling or connection issue on the robot, the radio ping should remain "GOOD".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the radio was supposed to reboot faster then the old radio

@@ -27,7 +27,7 @@ Support for Cross The Road Electronics components (Pneumatics Control Module, Po

## REV Robotics Support

Support for REV Robotics components (SPARK MAX, Sensors, Pneumatic Hub, Power Distribution Hub, Radio Power Module) is provided via phone at [844-255-2267](tel:844-255-2267) or via the email address [[email protected]](mailto:[email protected]).
Support for REV Robotics components (SPARK MAX, Sensors, Pneumatic Hub, Power Distribution Hub) is provided via phone at [844-255-2267](tel:844-255-2267) or via the email address [[email protected]](mailto:[email protected]).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with keeping this reference to RPM

@@ -236,7 +239,6 @@
[REV Robotics](https://www.revrobotics.com/) - inspires innovation and creativity within the educational robotics community by offering comprehensive product lines, extensive educational resources, world-class customer service, and specialized sponsorship programs. With a global presence spanning over 190 countries, we empower the next generation of STEM professionals by providing cutting-edge solutions and essential tools for success. Founded in 2014 by robotics enthusiasts Greg Needel and David Yanoshak, REV Robotics is driven by the mission to inspire and support students as they explore the exciting world of robotics and unlock their full robotic design potential. A majority of our employees are FIRST Alumni who remain actively involved, serving as volunteers and mentors for the local FIRST Community. This deep engagement reflects our commitment to supporting and inspiring the next generation of STEM enthusiasts.

RPM
Radio Power Module - is designed to keep one of the most critical system components, the OpenMesh OM5P-AC WiFi radio, powered in the toughest moments of the competition.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with keeping this definition of the RPM

@@ -338,49 +339,39 @@ After making the connection check to be sure that it is clean and secure:


## Radio Power
[Vivid-Hosting Wiring Guide](https://frc-radio.vivid-hosting.net/getting-started/usage/wiring-your-radio)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a formatting issue. I think it needs a new line below


.. warning:: It is not possible to modify the configuration manually.
5. Enter the 2.4 GHz WPA/SAE key. This is the password team members will type in when connecting to the 2.4 GHz network, if available.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this used for?


## Prerequisites

The FRC Radio Configuration Utility requires administrator privileges to configure the network settings on your machine. The program should request the necessary privileges automatically (may require a password if run from a non-administrator account), but if you are having trouble, try running it from an administrator account.
The recommended setup requires: 2 VH-109 radios, 1 VH-117 :term:`PoE` Wall Adapter, and 1 Radio Heatsink. Available [here](https://wcproducts.com/products/frc-radio).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like it could really use a picture to show how everything works together.


## Allow the program to make changes, if prompted
If your team still has an older radio from a previous season, it can serve as a temporary substitute for the VH-109 on your robot. In this case, you should:
- Reserve a spot on your robot specifically for the VH-109 radio to ensure seamless integration during competition.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting issues with all the lists in this section. Think there needs to be some more newlines

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add WCP support here, now that they are a KOP vendor

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The video and some of the pictures still has the old radio. Should add some kind of call-out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Documentation links for the Vivid Hosting Radios
3 participants