From 0ae288292145b594e383c42896958e0876d56946 Mon Sep 17 00:00:00 2001 From: Ben Huson Date: Fri, 22 Feb 2019 21:18:23 +0000 Subject: [PATCH 1/2] Check that `$_SERVER['REMOTE_ADDR']` is set. --- admin/admin.php | 7 ++++++- password-protected.php | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/admin/admin.php b/admin/admin.php index 2b929e1..3e8b3b5 100644 --- a/admin/admin.php +++ b/admin/admin.php @@ -283,7 +283,12 @@ public function password_protected_password_field() { public function password_protected_allowed_ip_addresses_field() { echo ''; - echo '

' . esc_html__( 'Enter one IP address per line.', 'password-protected' ) . ' ' . esc_html( sprintf( __( 'Your IP is address %s.', 'password-protected' ), $_SERVER['REMOTE_ADDR'] ) ) . '

'; + + echo '

' . esc_html__( 'Enter one IP address per line.', 'password-protected' ); + if ( isset( $_SERVER['REMOTE_ADDR'] ) ) { + echo ' ' . esc_html( sprintf( __( 'Your IP is address %s.', 'password-protected' ), $_SERVER['REMOTE_ADDR'] ) ); + } + echo '

'; } diff --git a/password-protected.php b/password-protected.php index 39af025..4fa43dd 100644 --- a/password-protected.php +++ b/password-protected.php @@ -226,7 +226,7 @@ public function allow_ip_addresses( $bool ) { $ip_addresses = $this->get_allowed_ip_addresses(); - if ( in_array( $_SERVER['REMOTE_ADDR'], $ip_addresses ) ) { + if ( isset( $_SERVER['REMOTE_ADDR'] ) && in_array( $_SERVER['REMOTE_ADDR'], $ip_addresses ) ) { $bool = false; } From 0a961cb998e56334e2c01375758bf6ed6a2cde8c Mon Sep 17 00:00:00 2001 From: Ben Huson Date: Fri, 22 Feb 2019 22:09:16 +0000 Subject: [PATCH 2/2] Version 2.2.4 --- CHANGELOG.md | 8 +++++++- README.md | 3 +++ password-protected.php | 4 ++-- readme.txt | 7 +++++-- 4 files changed, 17 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6f2c359..53b3416 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,11 @@ This project adheres to [Semantic Versioning](http://semver.org/). ## [Unreleased] +## [2.2.4] - 2019-02-22 + +### Fixed +Check that `$_SERVER['REMOTE_ADDR']` is set. + ## [2.2.3] - 2019-01-10 ### Fixed @@ -212,7 +217,8 @@ This project adheres to [Semantic Versioning](http://semver.org/). ### Added - First Release. If you spot any bugs or issues please [log them here](https://github.com/benhuson/password-protected/issues). -[Unreleased]: https://github.com/benhuson/password-protected/compare/2.2.3...HEAD +[Unreleased]: https://github.com/benhuson/password-protected/compare/2.2.4...HEAD +[2.2.4]: https://github.com/benhuson/password-protected/compare/2.2.3...2.2.4 [2.2.3]: https://github.com/benhuson/password-protected/compare/2.2.2...2.2.3 [2.2.2]: https://github.com/benhuson/password-protected/compare/2.2.1...2.2.2 [2.2.1]: https://github.com/benhuson/password-protected/compare/2.2...2.2.1 diff --git a/README.md b/README.md index 083cd23..ac089b0 100644 --- a/README.md +++ b/README.md @@ -71,6 +71,9 @@ More instructions can be found at [wp-translations.org](http://wp-translations.o Upgrade Notice -------------- +### 2.2.4 +Check that `$_SERVER['REMOTE_ADDR']` is set. + ### 2.2.3 Restrict REST-API-access only if password protection is active. Added viewport meta tag to login page. diff --git a/password-protected.php b/password-protected.php index 4fa43dd..01afa34 100644 --- a/password-protected.php +++ b/password-protected.php @@ -4,7 +4,7 @@ Plugin Name: Password Protected Plugin URI: https://wordpress.org/plugins/password-protected/ Description: A very simple way to quickly password protect your WordPress site with a single password. Please note: This plugin does not restrict access to uploaded files and images and does not work with some caching setups. -Version: 2.2.3 +Version: 2.2.4 Author: Ben Huson Text Domain: password-protected Author URI: http://github.com/benhuson/password-protected/ @@ -42,7 +42,7 @@ class Password_Protected { - var $version = '2.2.3'; + var $version = '2.2.4'; var $admin = null; var $errors = null; diff --git a/readme.txt b/readme.txt index f13c47e..3c42b3c 100644 --- a/readme.txt +++ b/readme.txt @@ -3,9 +3,9 @@ Contributors: husobj Donate link: https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=DXRJDNCMK9U3N Tags: password, protect, password protect, login Requires at least: 3.9 -Tested up to: 4.9.6 +Tested up to: 5.1 Requires PHP: 5.6 -Stable tag: 2.2.3 +Stable tag: 2.2.4 License: GPLv2 or later A very simple way to quickly password protect your WordPress site with a single password. @@ -82,6 +82,9 @@ More instructions can be found at [wp-translations.org](http://wp-translations.o == Changelog == += 2.2.4 = +- Check that `$_SERVER['REMOTE_ADDR']` is set. + = 2.2.3 = - Restrict REST-API-access only if password protection is active. - Added viewport meta tag to login page.