new #168
Open
new #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyobin-yang
reviewed
Nov 29, 2024
hyobin-yang
left a comment
hyobin-yang
left a comment
There was a problem hiding this comment.
미리 자기만의 컨벤션을 만들어두면 그나마 시간을 많이 줄일 수 있더라구요
아직 저도 시간 맞추는 게 넘 어렵긴 하지만요ㅎㅎㅠㅜ
수고하셨습니당
| System.out.println(backendCrew); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
이 부분 출력 요구사항에 없었던 것 같은데 첨에 확인 차원에서 넣으신 부분인가용?
| e.printStackTrace(); | ||
| } | ||
| return backendCrewNames; | ||
| } |
There was a problem hiding this comment.
파일 입출력에 관해서 io 계층을 만들고 거기서 파일을 읽고 그걸 컨트롤러에서 사용할 수 있게 구현하는 것도 좋을 것 같숩니다
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| public class CrewsPerBackend { |
There was a problem hiding this comment.
이미 BackendCrew라는 클래스를 두어서 백엔드 크루 객체가 그 의미(백 or 프론트)를 표현하고 있어서 CrewsPer~ 계층을 두 개를 두어서 구분할 필요는 없을 것 같다는 생각이 듭니당!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.