-
Notifications
You must be signed in to change notification settings - Fork 461
[페어 매칭] 코드 리뷰 #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devFancy
wants to merge
43
commits into
woowacourse:main
Choose a base branch
from
devFancy:fancy-review
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[페어 매칭] 코드 리뷰 #156
+844
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring MVC 패턴으로 처음 미션을 수행해서 의도치 않게 클래스를 많이 생성했습니다😅
이후에 추가적으로 리팩토링하면서 깔끔한 코드로 만들도록 하겠습니다.
docs패키지 안의 README.md 파일에 각각의 패키지와 클래스의 역할을 설명했습니다.
코드의 구조는 다음과 같습니다.
클래스 다이어그램은 다음과 같습니다.
Controller(빨간색)부분과 Repository(파랑색)를 기준으로 나머지를 봐주시면 조금이나마 이해가 되실 것 같습니다.
이후에는 테스트코드 작성 및 리팩토링하도록 하겠습니다.🥰
감사합니다.