abseil-cpp 20240722 FTBFS after the introduction of openssf-compiler-options
as described in wolfi-dev#34075. grpc-1.67 vendors in abseil-cpp 20240116, an older
LTS release that is still upstream supported for another year. Workaround
the FTBFS by using the vendored copy instead of a system package. This
also means we need to switch to vendored copies of protobuf and re2, as
installing those apks will bring in the problematic abseil-cpp apk.

Signed-off-by: dann frazier <[email protected]>

abseil-cpp 20240722 FTBFS after the introduction of openssf-compiler-options
as described in wolfi-dev#34075. grpc-1.67 vendors in abseil-cpp 20240116, an older
LTS release that is still upstream supported for another year. Workaround
the FTBFS by using the vendored copy instead of a system package. This
also means we need to switch to vendored copies of protobuf and re2, as
installing those apks will bring in the problematic abseil-cpp apk.

Signed-off-by: dann frazier <[email protected]>

abseil-cpp and packages that use it began to FTBFS after the introduction of
openssf-compiler-options, specifically its addition of the
-fno-delete-null-pointer-checks flag. This is believed to be a GCC bug:
  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71962

Unfortunately it isn't possible to "undo" this flag by appending the
inverse flag (-fdelete-null-pointer-checks). So here we introduce a
new spec file for abseil-cpp builds that will filter out the
problematic flag from the openssf spec file. Fixes wolfi-dev#34075.

Signed-off-by: dann frazier <[email protected]>

abseil-cpp and packages that use it began to FTBFS after the introduction of
openssf-compiler-options, specifically its addition of the
-fno-delete-null-pointer-checks flag. This is believed to be a GCC bug:
  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71962

Unfortunately it isn't possible to "undo" this flag by appending the
inverse flag (-fdelete-null-pointer-checks). So here we introduce a
new spec file for abseil-cpp builds that will filter out the
problematic flag from the openssf spec file. Fixes wolfi-dev#34075.

This commit uses the spec file to build abseil-cpp itself, and
ships it in the abseil-cpp-dev apk so abseil-cpp's reverse
dependencies can be updated to use it.

Signed-off-by: dann frazier <[email protected]>

abseil-cpp and packages that use it began to FTBFS after the introduction of
openssf-compiler-options, specifically its addition of the
-fno-delete-null-pointer-checks flag. This is believed to be a GCC bug:
  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71962

Unfortunately it isn't possible to "undo" this flag by appending the
inverse flag (-fdelete-null-pointer-checks). So here we introduce a
new spec file for abseil-cpp builds that will filter out the
problematic flag from the openssf spec file. Fixes wolfi-dev#34075.

This commit uses the spec file to build abseil-cpp itself, and
ships it in the abseil-cpp-dev apk so abseil-cpp's reverse
dependencies can be updated to use it.

Signed-off-by: dann frazier <[email protected]>

abseil-cpp and packages that use it began to FTBFS after the introduction of
openssf-compiler-options, specifically its addition of the
-fno-delete-null-pointer-checks flag. This is believed to be a GCC bug:
  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71962

Unfortunately it isn't possible to "undo" this flag by appending the
inverse flag (-fdelete-null-pointer-checks). So here we introduce a
new spec file for abseil-cpp builds that will filter out the
problematic flag from the openssf spec file. Fixes wolfi-dev#34075.

This commit uses the spec file to build abseil-cpp itself, and
ships it in the abseil-cpp-dev apk so abseil-cpp's reverse
dependencies can be updated to use it.

Signed-off-by: dann frazier <[email protected]>

abseil-cpp and packages that use it began to FTBFS after the introduction of
openssf-compiler-options, specifically its addition of the
-fno-delete-null-pointer-checks flag. This is believed to be a GCC bug:
  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71962

Unfortunately it isn't possible to "undo" this flag by appending the
inverse flag (-fdelete-null-pointer-checks). So here we introduce a
new spec file for abseil-cpp builds that will filter out the
problematic flag from the openssf spec file. Fixes wolfi-dev#34075.

This commit uses the spec file to build abseil-cpp itself, and
ships it in the abseil-cpp-dev apk so abseil-cpp's reverse
dependencies can be updated to use it.

Signed-off-by: dann frazier <[email protected]>

abseil-cpp and packages that use it began to FTBFS after the introduction of
openssf-compiler-options, specifically its addition of the
-fno-delete-null-pointer-checks flag. This is believed to be a GCC bug:
  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71962

Unfortunately it isn't possible to "undo" this flag by appending the
inverse flag (-fdelete-null-pointer-checks). So here we introduce a
new spec file for abseil-cpp builds that will filter out the
problematic flag from the openssf spec file. Fixes wolfi-dev#34075.

This commit uses the spec file to build abseil-cpp itself, and
ships it in the abseil-cpp-dev apk so abseil-cpp's reverse
dependencies can be updated to use it.

Signed-off-by: dann frazier <[email protected]>

abseil-cpp and packages that use it began to FTBFS after the introduction of
openssf-compiler-options, specifically its addition of the
-fno-delete-null-pointer-checks flag. This is believed to be a GCC bug:
  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71962

Unfortunately it isn't possible to "undo" this flag by appending the
inverse flag (-fdelete-null-pointer-checks). So here we introduce a
new spec file for abseil-cpp builds that will filter out the
problematic flag from the openssf spec file. Fixes wolfi-dev#34075.

This commit uses the spec file to build abseil-cpp itself, and
ships it in the abseil-cpp-dev apk so abseil-cpp's reverse
dependencies can be updated to use it.

Signed-off-by: dann frazier <[email protected]>

abseil-cpp and packages that use it began to FTBFS after the introduction of
openssf-compiler-options, specifically its addition of the
-fno-delete-null-pointer-checks flag. This is believed to be a GCC bug:
  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71962

Unfortunately it isn't possible to "undo" this flag by appending the
inverse flag (-fdelete-null-pointer-checks). So here we introduce a
new spec file for abseil-cpp builds that will filter out the
problematic flag from the openssf spec file. Fixes wolfi-dev#34075.

This commit uses the spec file to build abseil-cpp itself, and
ships it in the abseil-cpp-dev apk so abseil-cpp's reverse
dependencies can be updated to use it.

Signed-off-by: dann frazier <[email protected]>

…C bug

abseil-cpp and packages that use it began to FTBFS after the introduction of
openssf-compiler-options, specifically its addition of the
-fno-delete-null-pointer-checks flag. This is believed to be a GCC bug:
  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71962

Unfortunately it isn't possible to "undo" this flag by appending the
inverse flag (-fdelete-null-pointer-checks). So here we introduce a
new package that provides a spec file that will filter out the
problematic flag from the openssf spec file. Fixes wolfi-dev#34075.

This commit uses the spec file to build abseil-cpp itself, and
ships it in the abseil-cpp-compiler-options apk so abseil-cpp's reverse
dependencies, as well as packages that vendor their own abseil-cpp source,
can be updated to use it.

Signed-off-by: dann frazier <[email protected]>

See: wolfi-dev#34075

Signed-off-by: dann frazier <[email protected]>

See: wolfi-dev#34075

Signed-off-by: dann frazier <[email protected]>

…tions

See: wolfi-dev#34075

Signed-off-by: dann frazier <[email protected]>

See: wolfi-dev#34075

Signed-off-by: dann frazier <[email protected]>

See: wolfi-dev#34075

Signed-off-by: dann frazier <[email protected]>

See: wolfi-dev#34075

Signed-off-by: dann frazier <[email protected]>

See: wolfi-dev#34075

Signed-off-by: dann frazier <[email protected]>

See: wolfi-dev#34075

Signed-off-by: dann frazier <[email protected]>

…C bug

abseil-cpp and packages that use it began to FTBFS after the introduction of
openssf-compiler-options, specifically its addition of the
-fno-delete-null-pointer-checks flag. This is believed to be a GCC bug:
  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71962

Unfortunately it isn't possible to "undo" this flag by appending the
inverse flag (-fdelete-null-pointer-checks). So here we introduce a
new package that provides a spec file that will filter out the
problematic flag from the openssf spec file. Fixes wolfi-dev#34075.

This commit uses the spec file to build abseil-cpp itself, and
ships it in the abseil-cpp-compiler-options apk so abseil-cpp's reverse
dependencies, as well as packages that vendor their own abseil-cpp source,
can be updated to use it.

Signed-off-by: dann frazier <[email protected]>

See: wolfi-dev#34075

Signed-off-by: dann frazier <[email protected]>

See: wolfi-dev#34075

Signed-off-by: dann frazier <[email protected]>

…tions

See: wolfi-dev#34075

Signed-off-by: dann frazier <[email protected]>

See: wolfi-dev#34075

Signed-off-by: dann frazier <[email protected]>

See: wolfi-dev#34075

Signed-off-by: dann frazier <[email protected]>

See: wolfi-dev#34075

Signed-off-by: dann frazier <[email protected]>

See: wolfi-dev#34075

Signed-off-by: dann frazier <[email protected]>

See: wolfi-dev#34075

Signed-off-by: dann frazier <[email protected]>

See wolfi-dev#34075

Signed-off-by: dann frazier <[email protected]>

See: #34075

Signed-off-by: dann frazier <[email protected]>

See #34075

Signed-off-by: dann frazier <[email protected]>

See #34075

Signed-off-by: dann frazier <[email protected]>

Related:
- chainguard-dev/internal-dev#5334
- #34075 (abseil/openssf-related
FTBFS)

See individual commit logs for details.

---------

Signed-off-by: dann frazier <[email protected]>

See wolfi-dev#34075

Signed-off-by: dann frazier <[email protected]>

Until `abseil-cpp-compiler-options` is available (which is blocked
by a melange/apko issue), let's disable openssf-compiler-options
to unblock building this package.

See wolfi-dev#34075

Signed-off-by: dann frazier <[email protected]>

See #34075

Signed-off-by: dann frazier <[email protected]>

Using -fdelete-null-pointer to "undo" this flag is not sufficient
due to a GCC bug[*]. So let's tell the spec file to just omit
-fno-delete-null-pointer if -fdelete-null-pointer was explicitly
passed. This will give us a path to workaround build failures
in software that is incompatible with this flag (notably
abseil-cpp).

Fixes: wolfi-dev#34075

[*] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71962

Signed-off-by: dann frazier <[email protected]>

Fixes: wolfi-dev#34075

Signed-off-by: dann frazier <[email protected]>

Add explicit build-dep on openssf-compiler-options so that CI
orders the builds correctly.

Fixes: wolfi-dev#34075

Signed-off-by: dann frazier <[email protected]>

Using -fdelete-null-pointer to "undo" this flag is not sufficient
due to a GCC bug[*]. So let's tell the spec file to just omit
-fno-delete-null-pointer if -fdelete-null-pointer was explicitly
passed. This will give us a path to workaround build failures
in software that is incompatible with this flag (notably
abseil-cpp).

Generated with this command:
  sed -i 's/-fno-delete-null-pointer-checks/%{!fdelete-null-pointer-checks:-fno-delete-null-pointer-checks}/' openssf-compiler-options/usr/lib/gcc/*/*/openssf.spec

Fixes: wolfi-dev#34075

[*] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71962

Signed-off-by: dann frazier <[email protected]>

Add explicit build-dep on openssf-compiler-options so that CI
orders the builds correctly.

Fixes: wolfi-dev#34075

Signed-off-by: dann frazier <[email protected]>

Add explicit build-dep on openssf-compiler-options so that CI
orders the builds correctly.

Fixes: wolfi-dev#34075

Signed-off-by: dann frazier <[email protected]>

Add explicit build-dep on openssf-compiler-options so that CI
orders the builds correctly.

While this fixes a FTBFS, allowing a new abseil-cpp into the
archive would trigger an issue in current versions of melange[*],
so I'm avoiding bumping the epoch at this time.

Fixes: wolfi-dev#34075

[*] chainguard-dev/melange#1651

Signed-off-by: dann frazier <[email protected]>

Using -fdelete-null-pointer to "undo" this flag is not sufficient
due to a GCC bug[*]. So let's tell the spec file to just omit
-fno-delete-null-pointer if -fdelete-null-pointer was explicitly
passed. This will give us a path to workaround build failures
in software that is incompatible with this flag (notably
abseil-cpp).

Generated with this command:
  sed -i 's/-fno-delete-null-pointer-checks/%{!fdelete-null-pointer-checks:-fno-delete-null-pointer-checks}/' openssf-compiler-options/usr/lib/gcc/*/*/openssf.spec

Fixes: wolfi-dev#34075

[*] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71962

Signed-off-by: dann frazier <[email protected]>

Add explicit build-dep on openssf-compiler-options so that CI
orders the builds correctly.

While this fixes a FTBFS, allowing a new abseil-cpp into the
archive would trigger an issue in current versions of melange[*],
so I'm avoiding bumping the epoch at this time.

Fixes: wolfi-dev#34075

[*] chainguard-dev/melange#1651

Signed-off-by: dann frazier <[email protected]>

…inter

abseil-cpp and its reverse dependencies (including those that vendor their own copy) FTBFS with an option from openssf-compiler-options (-fno-delete-null-pointer-checks). A GCC bug means this can't be undone by just adding the inverse flag to CXXFLAGS or similar. This adds logic to openssf-compiler-options to not pass the breaking flag at all iff the inverse flag is provided.

This adds the inverse flag to all impacted packages. It bumps all of them except abseil-cpp itself, because doing so would trigger an unrelated bug in melange, which I've described in a comment within.

Fixes: #34075