Lint - fix overriding local import specifier (#772)

Author: M-i-k-e-l

eslint-rules/lib/rules/assets-deprecation.js

@@ -79,7 +79,7 @@ module.exports = {
     }
 
     return {
-      ImportDeclaration: node => setLocalImportSpecifier(node),
+      ImportDeclaration: node => !localImportSpecifier && setLocalImportSpecifier(node),
       MemberExpression: node => localImportSpecifier && testMemberDeprecation(node),
 
 

eslint-rules/lib/rules/typography-deprecation.js

@@ -68,7 +68,7 @@ module.exports = {
     }
 
     return {
-      ImportDeclaration: node => setLocalImportSpecifier(node),
+      ImportDeclaration: node => !localImportSpecifier && setLocalImportSpecifier(node),
       MemberExpression: node => localImportSpecifier && testMemberDeprecation(node),
       JSXAttribute: node => testJSXAttribute(node),
 

eslint-rules/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-uilib",
-  "version": "1.0.21",
+  "version": "1.0.23",
   "description": "uilib set of eslint rules",
   "keywords": [
     "eslint",

eslint-rules/tests/lib/rules/assets-deprecation.js

@@ -12,6 +12,7 @@ const ruleTester = new RuleTester();
 
 const ourSource = 'our-source';
 const notOurSource = 'another-source';
+const notOurSource2 = 'another-source-2';
 
 const options = [{deprecations: deprecationsJson, source: ourSource}];
 const optionsWithDate = [{deprecations: deprecationsJson, source: ourSource, dueDate: '2 November, Friday'}];
@@ -116,7 +117,9 @@ class Example extends Component {
 }`;
 
 const fullClassTest1 = `
+import {Something} from '${notOurSource}';
 ${ourImport}
+import {SomethingElse} from '${notOurSource2}';
   
 const validIcon = (icon) => (typeof icon === 'number' ? icon : undefined);
 

eslint-rules/tests/lib/rules/typography-deprecation.js

@@ -12,6 +12,7 @@ const ruleTester = new RuleTester();
 
 const ourSource = 'our-source';
 const notOurSource = 'another-source';
+const notOurSource2 = 'another-source-2';
 
 const options = [{deprecations: deprecationsJson, source: ourSource}];
 const optionsWithDate = [{deprecations: deprecationsJson, source: ourSource, dueDate: '2 November, Friday'}];
@@ -124,7 +125,9 @@ class Example extends Component {
 }`;
 
 const fullClassTest1 = `
+import {Something} from '${notOurSource}';
 ${ourImport}
+import {SomethingElse} from '${notOurSource2}';
   
 const validTypography = (typography) => (myLogic(typography) ? typography : undefined);