Skip to content

Commit 6f2f1e9

Browse files
liucijusWixBuildServer
authored andcommitted
Fix root detection
1 parent 0f30090 commit 6f2f1e9

File tree

1 file changed

+2
-45
lines changed

1 file changed

+2
-45
lines changed

base/src/com/google/idea/blaze/base/sync/libraries/LibraryModifier.java

+2-45
Original file line numberDiff line numberDiff line change
@@ -20,23 +20,16 @@
2020
import com.google.idea.blaze.base.model.LibraryFilesProvider;
2121
import com.intellij.openapi.diagnostic.Logger;
2222
import com.intellij.openapi.externalSystem.service.project.IdeModifiableModelsProvider;
23-
import com.intellij.openapi.progress.DumbProgressIndicator;
2423
import com.intellij.openapi.roots.OrderRootType;
2524
import com.intellij.openapi.roots.libraries.Library;
2625
import com.intellij.openapi.roots.libraries.Library.ModifiableModel;
27-
import com.intellij.openapi.roots.libraries.ui.RootDetector;
28-
import com.intellij.openapi.roots.ui.configuration.LibrarySourceRootDetectorUtil;
2926
import com.intellij.openapi.util.io.FileUtil;
3027
import com.intellij.openapi.util.io.FileUtilRt;
31-
import com.intellij.openapi.vfs.JarFileSystem;
32-
import com.intellij.openapi.vfs.LocalFileSystem;
3328
import com.intellij.openapi.vfs.StandardFileSystems;
3429
import com.intellij.openapi.vfs.VirtualFile;
3530
import com.intellij.openapi.vfs.VirtualFileManager;
3631
import com.intellij.util.io.URLUtil;
3732
import java.io.File;
38-
import java.util.ArrayList;
39-
import java.util.List;
4033

4134
/**
4235
* Modifies {@link Library} content in {@link Library.ModifiableModel}.
@@ -66,47 +59,11 @@ public void updateModifiableModel(BlazeProjectData blazeProjectData) {
6659
addRoot(classFileUrl, OrderRootType.CLASSES);
6760
}
6861

69-
for (String sourceFileUrl : libraryFilesProvider.getSourceFilesUrls(blazeProjectData)) {
70-
detectSourceRoots(sourceFileUrl).forEach(root -> {
71-
modifiableModel.addRoot(root, OrderRootType.SOURCES);
72-
});
62+
for (String sourceFile : libraryFilesProvider.getSourceFilesUrls(blazeProjectData)) {
63+
addRoot(sourceFile, OrderRootType.SOURCES);
7364
}
7465
}
7566

76-
private List<VirtualFile> detectSourceRoots(String sourceJar) {
77-
List<VirtualFile> roots = new ArrayList<>();
78-
79-
if (sourceJar == null) {
80-
return roots;
81-
}
82-
83-
VirtualFile srcFile = LocalFileSystem.getInstance().refreshAndFindFileByPath(sourceJar);
84-
if (srcFile == null) {
85-
return roots;
86-
}
87-
88-
VirtualFile jarRoot = JarFileSystem.getInstance().getJarRootForLocalFile(srcFile);
89-
if (jarRoot == null) {
90-
return roots;
91-
}
92-
93-
List<RootDetector> detectors = LibrarySourceRootDetectorUtil.JAVA_SOURCE_ROOT_DETECTOR
94-
.getExtensionList();
95-
96-
return detect(detectors, jarRoot);
97-
}
98-
99-
private List<VirtualFile> detect(List<RootDetector> detectors, VirtualFile jarRoot) {
100-
List<VirtualFile> roots = new ArrayList<>();
101-
102-
for (RootDetector detector : detectors) {
103-
DumbProgressIndicator progressIndicator = new DumbProgressIndicator();
104-
roots.addAll(detector.detectRoots(jarRoot, progressIndicator));
105-
}
106-
107-
return roots;
108-
}
109-
11067
private ModifiableModel getLibraryModifiableModel(
11168
IdeModifiableModelsProvider modelsProvider, String libraryName) {
11269
Library library = modelsProvider.getLibraryByName(libraryName);

0 commit comments

Comments
 (0)