Skip to content

Commit 1bb3e56

Browse files
author
Oluwafemi Adenuga
committed
Refactor file download method
1 parent 609661f commit 1bb3e56

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

elorus/client.py

+7-3
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,13 @@ def _get_auth(self):
4040
)
4141

4242
def handle_file_download(self, response):
43-
filename = response.headers.get("Content-Disposition", None)
44-
if filename:
45-
filename = filename.split("filename=")[1]
43+
content_disposition = response.headers.get("Content-Disposition", "")
44+
if "filename=" not in content_disposition:
45+
raise ValueError("No filename found in Content-Disposition header")
46+
filename_kv = content_disposition.split("filename=")
47+
if len(filename_kv) < 2:
48+
raise ValueError("Invalid Content-Disposition header format")
49+
filename = filename_kv[1]
4650
return filename, response.content
4751

4852
def _handle_response(self, response):

0 commit comments

Comments
 (0)