Skip to content

Conversation

Fryuni
Copy link
Member

@Fryuni Fryuni commented Aug 31, 2025

Changes

Mark files that rely on syscall/js with build tags targeting JS and WASM, the same as the syscall/js package itself.

GoPls shows this warning when working on the project locally so things get annoying with tools that aim to keep the project always green like preventing commits in a broken state without extra confirmation jumping to definitions to explore the codebase since it consider those references broken.

image

Which then makes GoPls consider all the imports that are JS-only as exporting nothing:

image

Additionally, go.mod had a dependency marked as indirect but it is actually used directly by our tests. So just running go mod tidy causes the changes committed there.

Copy link

changeset-bot bot commented Aug 31, 2025

⚠️ No Changeset found

Latest commit: be823c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Fryuni Fryuni changed the title Fix LSP warnings Fix LSP warnings and navigation on JS-related code Aug 31, 2025
@Fryuni Fryuni merged commit 893a703 into main Aug 31, 2025
5 checks passed
@Fryuni Fryuni deleted the fix-lsp-project-errors branch August 31, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants