Fix LSP warnings and navigation on JS-related code #1106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Mark files that rely on
syscall/js
with build tags targeting JS and WASM, the same as thesyscall/js
package itself.GoPls shows this warning when working on the project locally so things get annoying with tools that aim to keep the project always green like preventing commits in a broken state without extra confirmation jumping to definitions to explore the codebase since it consider those references broken.
Which then makes GoPls consider all the imports that are JS-only as exporting nothing:
Additionally,
go.mod
had a dependency marked as indirect but it is actually used directly by our tests. So just runninggo mod tidy
causes the changes committed there.