Fix scoping issue with pseudo selectors #1100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes a CSS scoping issue when a compound selector does not contain a type selector and all the subclass selectors are pseudo selectors (e.g. pseudo-classes and pseudo-elements).
To fix this issue, when hitting a pseudo selector for the first time in a compound selector, if there is no type selector, we check if all the subclass selectors are pseudo selectors (this check is only done once per compound selector). If so, we add the scope before the first pseudo selector.
Testing
I added tests matching all the test cases reported in the issue.
Docs
This is a bug fix only, so no docs were added or updated.