Skip to content

Conversation

@HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Aug 22, 2025

Changes

I noticed that the lint and lint-js jobs of the test workflow are failing. This PR fixes them both by:

  • lint:
    • Specify proper GOOS and GOARCH values when running the golangci/golangci-lint-action action
    • Update deprecated run.skip-dirs to issues.exclude-dirs configuration in .golangci.yml
    • Update deprecated run.skip-files to issues.exclude-files configuration in .golangci.yml
    • Remove unused typecheck configuration in .golangci.yml as typecheck errors cannot be skipped/ignored
    • Remove unused code in internal/printer/printer_test.go
  • lint-js:
    • Remove version: latest from the biomejs/setup-biome action so that the version is automatically detected from the project's dependencies

Note that this PR only fixes the linting jobs using the tooling we already have in place. I think the next step would be to update our tooling:

  • Update golangci/golangci-lint-action to the latest version (v8 as of writing) to use the latest version of golangci-lint (v2.4.0 as of writing)
  • Update @biomejs/biome to the latest version (v2.2.0 as of writing)

I think those should be done in a separate PR, as they might require some code changes, especially for the Go code as newer versions of golangci-lint introduce a lot of new rules and we want to choose which ones we want and don't want to enable carefully.

Testing

Run both jobs locally and also on my fork before creating the PR.

Docs

This is a CI change only, so no docs were added or updated.

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2025

⚠️ No Changeset found

Latest commit: a3ed586

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@HiDeoo HiDeoo merged commit 7331146 into withastro:main Aug 26, 2025
5 checks passed
jp-knj pushed a commit to jp-knj/compiler that referenced this pull request Aug 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants