Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I noticed that the
lintandlint-jsjobs of the test workflow are failing. This PR fixes them both by:lint:GOOSandGOARCHvalues when running thegolangci/golangci-lint-actionactionrun.skip-dirstoissues.exclude-dirsconfiguration in.golangci.ymlrun.skip-filestoissues.exclude-filesconfiguration in.golangci.ymltypecheckconfiguration in.golangci.ymlastypecheckerrors cannot be skipped/ignoredinternal/printer/printer_test.golint-js:version: latestfrom thebiomejs/setup-biomeaction so that the version is automatically detected from the project's dependenciesNote that this PR only fixes the linting jobs using the tooling we already have in place. I think the next step would be to update our tooling:
golangci/golangci-lint-actionto the latest version (v8 as of writing) to use the latest version ofgolangci-lint(v2.4.0 as of writing)@biomejs/biometo the latest version (v2.2.0 as of writing)I think those should be done in a separate PR, as they might require some code changes, especially for the Go code as newer versions of
golangci-lintintroduce a lot of new rules and we want to choose which ones we want and don't want to enable carefully.Testing
Run both jobs locally and also on my fork before creating the PR.
Docs
This is a CI change only, so no docs were added or updated.