Fix orphan slot panic (#370)

natemoo-re · web-flow · commit 15e3ff871f36 · 2022-04-21T14:29:35.000-05:00
* fix(#365): slot/head panic * test: add failing test * test: improve tests
diff --git a/.changeset/light-days-poke.md b/.changeset/light-days-poke.md
@@ -0,0 +1,5 @@
+---
+'@astrojs/compiler': patch
+---
+
+Fix panic when using a `<slot />` in `head`
diff --git a/internal/parser.go b/internal/parser.go
@@ -775,7 +775,9 @@ func inHeadIM(p *parser) bool {
 			return true
 		case a.Slot:
 			p.addElement()
-			p.setOriginalIM()
+			if p.originalIM == nil {
+				p.setOriginalIM()
+			}
 			if p.hasSelfClosingToken {
 				p.addLoc()
 				p.oe.pop()
diff --git a/internal/printer/printer_test.go b/internal/printer/printer_test.go
@@ -113,6 +113,20 @@ func TestPrinter(t *testing.T) {
 				code: `<html><head>${$$renderSlot($$result,$$slots["default"])}` + RENDER_HEAD_RESULT + `</head><body class="a"></body></html>`,
 			},
 		},
+		{
+			name:   "head slot III",
+			source: `<html><head><slot name="baseHeadExtension"><meta property="test2" content="test2"/></slot></head>`,
+			want: want{
+				code: `<html><head>${$$renderSlot($$result,$$slots["baseHeadExtension"],$$render` + BACKTICK + `<meta property="test2" content="test2">` + BACKTICK + `)}` + RENDER_HEAD_RESULT + `</head></html>`,
+			},
+		},
+		{
+			name:   "orphan slot",
+			source: `<slot />`,
+			want: want{
+				code: `${$$renderSlot($$result,$$slots["default"])}`,
+			},
+		},
 		{
 			name: "basic (frontmatter)",
 			source: `---
diff --git a/packages/compiler/deno/astro.wasm b/packages/compiler/deno/astro.wasm
diff --git a/packages/compiler/test/parse/orphan-slot.ts b/packages/compiler/test/parse/orphan-slot.ts
@@ -0,0 +1,28 @@
+import { test } from 'uvu';
+import * as assert from 'uvu/assert';
+import { transform } from '@astrojs/compiler';
+
+const FIXTURE = `
+---
+import { Code, Markdown } from 'astro/components';
+
+const {isRequired, description, example} = Astro.props;
+---
+
+<slot />
+{isRequired && <p class="mt-16 badge badge-info">Required</p>}
+{description?.trim() && <Markdown content={description} />}
+{example && <Code code={example} lang='yaml' />}
+`;
+
+let result;
+test.before(async () => {
+  result = await transform(FIXTURE);
+});
+
+test('orphan slot', () => {
+  assert.ok(result.code, 'able to parse');
+  console.log(result.code);
+});
+
+test.run();

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@astrojs/compiler': patch
 +---
++
 +Fix panic when using a `<slot />` in `head`