Skip to content

refactor(cli): create-key help display #14502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

refactor(cli): create-key help display #14502

wants to merge 5 commits into from

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Oct 7, 2025 •
edited
Loading

Changes

  • Depends on refactor(cli): create-key #14501
  • Updates the create-key command to display help, which involved creating a bunch of abstractions to allow unit testing. I understand it may seem overkill but it's really preparing the refactor of the next commands

Testing

Added unit tests

Docs

N/A, internal refactor

@florian-lefebvre florian-lefebvre self-assigned this Oct 7, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 96dc9d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 7, 2025
@florian-lefebvre florian-lefebvre changed the title refactor(cli): create-key/cre refactor(cli): create-key help display Oct 7, 2025
@florian-lefebvre florian-lefebvre marked this pull request as draft October 11, 2025 08:08
Base automatically changed from refactor/cli-create-key to main October 13, 2025 14:51
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 15, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #14502 will not alter performance

Comparing feat/cli-create-key-help-display (96dc9d7) with main (62ec8ea)1

Summary

✅ 6 untouched

Footnotes

  1. No successful run was found on main (6d68316) during the generation of this report, so 62ec8ea was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@florian-lefebvre florian-lefebvre marked this pull request as ready for review October 15, 2025 08:39
@ascorbic
Copy link
Contributor

Are we getting to the point where it would be better to introduce a CLI library, rather than effectively creating our own?

@florian-lefebvre
Copy link
Member Author

Not blocking for this PR as it mainly introduces CLI agnostic abstractions, but I'll look into it!

@florian-lefebvre
Copy link
Member Author

florian-lefebvre commented Oct 15, 2025 •
edited
Loading

https://github.com/bloomberg/stricli/ looks promising to me

EDIT: commander is better for us but it requires Node 20, so it can be introduced before v6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@florian-lefebvre florian-lefebvre

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@florian-lefebvre @ascorbic