-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Remove deprecated ViewTransitions component #14400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 68a2d95 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.
|
Some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'm re-running the failing testsn they're probably just flaky.
The docs team will comment on how we should proceed for v6 changes
|
@ellielok can you send a PR to the docs repo, against the |
Thanks for your reply. I've open a docs PR at withastro/docs#12347 |
|
Thank you for grabbing this issue and opening what I think is the very first PR for Astro v6.0!! Let's get this party started! 🥳 After the docs PR is finalized and approved, we can come back here and update the changeset to match! (Some people will prefer to have/read the upgrade guidance in the astro repo itself, so the changeset will be kind of a duplicate of what we put in the upgrade guide for docs.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bringing over upgrade guide content for the changeset!
Co-authored-by: Sarah Rainsberger <[email protected]>
First Astro 6 PR!!
Changes
ViewTransitionscomponent #14369Testing
All existing tests are passed when running
pnpm run testDocs
withastro/docs#12347