-
-
Notifications
You must be signed in to change notification settings - Fork 3k
feat: add SVGO optimization support for SVG assets #13880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
4e86a32
feat: add SVGO optimization support for SVG assets
azat-io ade3248
test: add SVGO optimization tests
azat-io e35fbfe
fix: improve svgo config zod schema
azat-io ddaacc3
chore: add changeset about adding svgo
azat-io b08081e
fix: make svgo optimization experimental
azat-io dd4b0c7
fix: fix svgo options jsdoc
azat-io debaaaf
chore: fix commit type and message
azat-io a6f1081
refactor: make fixes by review
azat-io bd7657c
Merge branch 'main' into feat/svgo
florian-lefebvre 1648350
refactor: make fixes by review
azat-io a9f447c
Merge branch 'main' into feat/svgo
florian-lefebvre ee8f98a
fix: build
florian-lefebvre 8986051
refactor: simplify svgo config
azat-io 3b067d5
feat: better error
florian-lefebvre 7361af9
Update packages/astro/src/core/errors/errors-data.ts
florian-lefebvre e582443
Update .changeset/cyan-tables-poke.md
florian-lefebvre fe09c99
Merge branch 'main' into feat/svgo
florian-lefebvre 66fc7d8
Merge branch 'main' into feat/svgo
florian-lefebvre 3df9ea6
Merge branch 'main' into feat/svgo
florian-lefebvre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| 'astro': minor | ||
| --- | ||
|
|
||
| Adds experimental SVGO optimization support for SVG assets | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
packages/astro/test/fixtures/core-image-svg-optimized/astro.config.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import { defineConfig } from 'astro/config'; | ||
|
|
||
| export default defineConfig({ | ||
| experimental: { | ||
| svg: { | ||
| optimize: true, | ||
| svgoConfig: { | ||
| plugins: [ | ||
| 'preset-default', | ||
| { | ||
| name: 'removeViewBox', | ||
| active: false | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| }); |
11 changes: 11 additions & 0 deletions
11
packages/astro/test/fixtures/core-image-svg-optimized/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "name": "@test/core-image-svg-optimized", | ||
| "version": "0.0.0", | ||
| "private": true, | ||
| "dependencies": { | ||
| "astro": "workspace:*" | ||
| }, | ||
| "scripts": { | ||
| "dev": "astro dev" | ||
| } | ||
| } |
16 changes: 16 additions & 0 deletions
16
packages/astro/test/fixtures/core-image-svg-optimized/src/assets/unoptimized.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
14 changes: 14 additions & 0 deletions
14
packages/astro/test/fixtures/core-image-svg-optimized/src/pages/optimized.astro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| --- | ||
| import TestIcon from '../assets/unoptimized.svg'; | ||
| --- | ||
|
|
||
| <html> | ||
| <head> | ||
| <title>SVG Optimization Test</title> | ||
| </head> | ||
| <body> | ||
| <div id="optimized"> | ||
| <TestIcon /> | ||
| </div> | ||
| </body> | ||
| </html> |
11 changes: 11 additions & 0 deletions
11
packages/astro/test/fixtures/core-image-svg-optimized/tsconfig.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "extends": "astro/tsconfigs/strict", | ||
| "compilerOptions": { | ||
| "baseUrl": ".", | ||
| "paths": { | ||
| "~/assets/*": [ | ||
| "src/assets/*" | ||
| ] | ||
| }, | ||
| } | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.