Reverse the behaviour

Author: ascorbic

packages/astro/src/core/app/index.ts

@@ -209,10 +209,12 @@ export class App {
 		if (this.#manifest.assets.has(url.pathname)) return undefined;
 		let pathname = this.#computePathnameFromDomain(request);
 		if (!pathname) {
-			pathname = prependForwardSlash(this.removeBase(url.pathname));
+			pathname = this.removeBase(url.pathname)
+			if(pathname !== '' || this.#manifest.base === '/') {
+				pathname = prependForwardSlash(pathname);
+			}
 		}
 		let routeData = matchRoute(decodeURI(pathname), this.#manifestData);
-
 		if (!routeData) return undefined;
 		if (allowPrerenderedRoutes) {
 			return routeData;

packages/astro/src/core/routing/manifest/pattern.ts

@@ -38,7 +38,7 @@ export function getPattern(
 	const trailing =
 		addTrailingSlash && segments.length ? getTrailingSlashPattern(addTrailingSlash) : '$';
 	let initial = '\\/';
-	if (addTrailingSlash === 'never' && base !== '/' && pathname !== '') {
+	if (addTrailingSlash === 'never' && base !== '/') {
 		initial = '';
 	}
 	return new RegExp(`^${pathname || initial}${trailing}`);

packages/astro/src/vite-plugin-astro-server/base.ts

@@ -30,7 +30,6 @@ export function baseMiddleware(
 
 		if (pathname.startsWith(devRoot)) {
 			req.url = url.replace(devRoot, devRootReplacement);
-			req.url ||= '/';
 			return next();
 		}
 

packages/astro/test/units/routing/manifest.test.js

@@ -37,7 +37,7 @@ function assertRouteRelations(routes, relations) {
 }
 
 describe('routing - createRoutesList', () => {
-	it('using trailingSlash: "never" matches the index route when it contains a trailing slash', async () => {
+	it('using trailingSlash: "never" does not match the index route when it contains a trailing slash', async () => {
 		const fixture = await createFixture({
 			'/src/pages/index.astro': `<h1>test</h1>`,
 		});
@@ -51,9 +51,8 @@ describe('routing - createRoutesList', () => {
 			settings,
 		});
 		const [{ pattern }] = manifest.routes;
-		// Requesting `/` *should* match the index route, because that's what it sees when requesting `/search`.
-		// If they've requested `/search/` this will have been caught by trailingSlashMiddleware
-		assert.equal(pattern.test('/'), true);
+		assert.equal(pattern.test(''), true);
+		assert.equal(pattern.test('/'), false);
 	});
 
 	it('endpoint routes are sorted before page routes', async () => {