Skip to content

Commit e03b19c

Browse files
committed
fix: 🐛 Fixed api.db.spec test
1 parent ad04611 commit e03b19c

File tree

2 files changed

+13
-8
lines changed

2 files changed

+13
-8
lines changed

src/node/api/db.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export interface User {
1313
/** The hashed password of the user */
1414
hashedPassword: string;
1515
/** Flag which indicate that the use is admin */
16-
isAdmin: boolean;
16+
isAdmin?: boolean;
1717
/** The optional JSON Web Token of the user */
1818
jwt?: string;
1919
}

test/node.api.db.spec.ts

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,41 @@
11
import { describe, beforeAll, it, expect } from './setup.js';
22
import { createInitializer } from '../src/storage/memory.js';
3-
import { UsersDb, UsersDbOptions, User } from '../src/node/api/db.js';
3+
import {
4+
UsersDb,
5+
UsersDbOptions,
6+
User,
7+
comparePassword,
8+
} from '../src/node/api/db.js';
49

510
describe('Node.API.Db', () => {
11+
const password = 'password';
612
let userDb: UsersDb;
713
let testUser: User;
814

915
beforeAll(async () => {
1016
const options: UsersDbOptions = {
1117
storage: await createInitializer()(),
1218
prefix: 'test',
13-
salt: 'salt',
1419
};
1520
userDb = new UsersDb(options);
1621
testUser = {
1722
login: 'testUser',
18-
hashedPassword: UsersDb.hashPassword('password', options.salt),
23+
hashedPassword: await UsersDb.hashPassword('password'),
1924
};
2025
});
2126

2227
describe('#add', () => {
2328
it('should add a new user', async () => {
24-
await userDb.add(testUser.login, 'password');
29+
await userDb.add(testUser.login, password);
2530
const user = await userDb.get(testUser.login);
2631
expect(user.login).to.be.eq(testUser.login);
27-
expect(user.hashedPassword).to.be.eq(testUser.hashedPassword);
32+
expect(await comparePassword(password, user.hashedPassword)).to.be.true;
2833
});
2934

3035
it('should throw an error when trying to add an existing user', async () => {
3136
let error = null;
3237
try {
33-
await userDb.add(testUser.login, 'password');
38+
await userDb.add(testUser.login, password);
3439
} catch (err) {
3540
error = err;
3641
}
@@ -45,7 +50,7 @@ describe('Node.API.Db', () => {
4550
it('should get a user', async () => {
4651
const user = await userDb.get(testUser.login);
4752
expect(user.login).to.be.eq(testUser.login);
48-
expect(user.hashedPassword).to.be.eq(testUser.hashedPassword);
53+
expect(await comparePassword(password, user.hashedPassword)).to.be.true;
4954
});
5055

5156
it('should throw an error when trying to get a non-existent user', async () => {

0 commit comments

Comments
 (0)