refactor(utils): consolidate size constants and remove unused code

- Move KB, MB, GB constants to module level for reuse
- Refactor format_size and format_transfer_rate to use shared constants
- Remove unused HTTP_TIMEOUT constant
- Remove unused HashMismatch error variant
- Remove futures dependency and related unused code
- Clean up comments in main.rs and downloader.rs

Signed-off-by: Martin Wimpress <martin@wimpress.org>

Author: flexiondotorg

Cargo.lock

@@ -12,7 +12,6 @@ edition = "2021"
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
-futures = "0.3.31"
 indicatif = "0.18.3"
 md5 = "0.8.0"
 regex = "1.12.2"

Cargo.toml

@@ -3,9 +3,6 @@
 /// User agent string for HTTP requests
 pub const USER_AGENT: &str = "ia-get";
 
-/// Timeout for all HTTP requests in seconds
-pub const HTTP_TIMEOUT: u64 = 60;
-
 /// Regex pattern for validating archive.org details URLs
 pub const URL_PATTERN: &str = r"^https://archive\.org/details/[a-zA-Z0-9_\-.@]+/?$";
 

src/constants.rs

@@ -8,7 +8,7 @@ use std::sync::Arc;
 
 use colored::*;
 use reqwest::header::{HeaderMap, HeaderValue};
-use reqwest::Client; // Add this line
+use reqwest::Client;
 
 use crate::error::IaGetError; // Import IaGetError for explicit error conversion
 use crate::utils::{create_progress_bar, format_duration, format_size, format_transfer_rate};

src/downloader.rs

@@ -20,10 +20,6 @@ pub enum IaGetError {
     #[error("Invalid archive.org URL: {0}. Expected format: https://archive.org/details/<identifier>[/]")]
     UrlFormat(String),
 
-    /// MD5 hash verification failures
-    #[error("Hash verification failed: {0}")]
-    HashMismatch(String),
-
     /// XML parsing errors
     #[error("Failed to parse XML: {0}")]
     XmlParsing(String),

src/error.rs

@@ -13,7 +13,7 @@ use ia_get::downloader;
 use ia_get::utils::{create_spinner, sanitize_filename, validate_archive_url};
 use ia_get::Result;
 use indicatif::ProgressStyle;
-use reqwest::Client; // Add this line
+use reqwest::Client;
 
 /// Extended timeout for large file downloads (10 minutes for connection, no read timeout)
 const CONNECTION_TIMEOUT_SECS: u64 = 600;

src/main.rs

@@ -5,11 +5,16 @@ use crate::{IaGetError, Result};
 use colored::*;
 use indicatif::{ProgressBar, ProgressStyle};
 use regex::Regex;
-use std::sync::LazyLock; // Add this line
+use std::sync::LazyLock;
 
 /// Spinner tick interval in milliseconds
 pub const SPINNER_TICK_INTERVAL: u64 = 100;
 
+/// Size constants for formatting
+const KB: u64 = 1024;
+const MB: u64 = KB * 1024;
+const GB: u64 = MB * 1024;
+
 /// Compiled regex for URL validation (initialized once)
 static URL_REGEX: LazyLock<Regex> =
     LazyLock::new(|| Regex::new(URL_PATTERN).expect("Invalid URL regex pattern"));
@@ -132,10 +137,6 @@ pub fn format_duration(duration: std::time::Duration) -> String {
 
 /// Format a size in bytes to a human-readable string
 pub fn format_size(size: u64) -> String {
-    const KB: u64 = 1024;
-    const MB: u64 = KB * 1024;
-    const GB: u64 = MB * 1024;
-
     if size < KB {
         format!("{}B", size)
     } else if size < MB {
@@ -149,18 +150,18 @@ pub fn format_size(size: u64) -> String {
 
 /// Format transfer rate to appropriate units
 pub fn format_transfer_rate(bytes_per_sec: f64) -> (f64, &'static str) {
-    const KB: f64 = 1024.0;
-    const MB: f64 = KB * 1024.0;
-    const GB: f64 = MB * 1024.0;
+    let kb = KB as f64;
+    let mb = MB as f64;
+    let gb = GB as f64;
 
-    if bytes_per_sec < KB {
+    if bytes_per_sec < kb {
         (bytes_per_sec, "B")
-    } else if bytes_per_sec < MB {
-        (bytes_per_sec / KB, "KB")
-    } else if bytes_per_sec < GB {
-        (bytes_per_sec / MB, "MB")
+    } else if bytes_per_sec < mb {
+        (bytes_per_sec / kb, "KB")
+    } else if bytes_per_sec < gb {
+        (bytes_per_sec / mb, "MB")
     } else {
-        (bytes_per_sec / GB, "GB")
+        (bytes_per_sec / gb, "GB")
     }
 }
 
@@ -304,11 +305,6 @@ pub fn sanitize_filename(filename: &str) -> (String, bool) {
         was_modified = true;
     }
 
-    // Check if result differs from original
-    if !was_modified {
-        was_modified = result != filename;
-    }
-
     (result, was_modified)
 }