CryptoKit ECDSA key encoding fixes

Author: whyoleg

cryptography-providers/cryptokit/src/commonMain/kotlin/algorithms/CryptoKitEcdsa.kt

@@ -86,7 +86,7 @@ private class EcdsaPublicKey(
     override fun encodeToByteArrayBlocking(format: EC.PublicKey.Format): ByteArray = when (format) {
         EC.PublicKey.Format.DER -> publicKey.derRepresentation().toByteArray()
         EC.PublicKey.Format.JWK -> error("JWK is not supported")
-        EC.PublicKey.Format.PEM -> publicKey.pemRepresentation().encodeToByteArray()
+        EC.PublicKey.Format.PEM -> (publicKey.pemRepresentation() + "\n").encodeToByteArray()
         EC.PublicKey.Format.RAW -> publicKey.rawRepresentation().toByteArray()
     }
 
@@ -108,7 +108,7 @@ private class EcdsaPrivateKey(
         EC.PrivateKey.Format.DER      -> privateKey.derRepresentation().toByteArray()
         EC.PrivateKey.Format.DER.SEC1 -> TODO()
         EC.PrivateKey.Format.JWK      -> error("JWK is not supported")
-        EC.PrivateKey.Format.PEM      -> privateKey.pemRepresentation().encodeToByteArray()
+        EC.PrivateKey.Format.PEM -> (privateKey.pemRepresentation() + "\n").encodeToByteArray()
         EC.PrivateKey.Format.PEM.SEC1 -> TODO()
         EC.PrivateKey.Format.RAW      -> privateKey.rawRepresentation().toByteArray()
     }

cryptography-providers/cryptokit/src/commonMain/swift/SwiftEcdsa.swift

@@ -23,15 +23,15 @@ import Foundation
         switch curve {
         case .p256:
             return SwiftEcdsaPublicKey(
-                key: try P256.Signing.PublicKey(rawRepresentation: rawRepresentation as Data),
+                key: try P256.Signing.PublicKey(x963Representation: rawRepresentation as Data),
                 curve: .p256)
         case .p384:
             return SwiftEcdsaPublicKey(
-                key: try P384.Signing.PublicKey(rawRepresentation: rawRepresentation as Data),
+                key: try P384.Signing.PublicKey(x963Representation: rawRepresentation as Data),
                 curve: .p384)
         case .p521:
             return SwiftEcdsaPublicKey(
-                key: try P521.Signing.PublicKey(rawRepresentation: rawRepresentation as Data),
+                key: try P521.Signing.PublicKey(x963Representation: rawRepresentation as Data),
                 curve: .p521)
         }
     }
@@ -122,9 +122,9 @@ import Foundation
 
     @objc public func rawRepresentation() -> Data {
         switch curve {
-        case .p256: return (key as! P256.Signing.PublicKey).rawRepresentation
-        case .p384: return (key as! P384.Signing.PublicKey).rawRepresentation
-        case .p521: return (key as! P521.Signing.PublicKey).rawRepresentation
+        case .p256: return (key as! P256.Signing.PublicKey).x963Representation
+        case .p384: return (key as! P384.Signing.PublicKey).x963Representation
+        case .p521: return (key as! P521.Signing.PublicKey).x963Representation
         }
     }