Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarchingCubes::compute_intersection_points is broken #1

Open
avaer opened this issue May 30, 2017 · 2 comments
Open

MarchingCubes::compute_intersection_points is broken #1

avaer opened this issue May 30, 2017 · 2 comments

Comments

@avaer
Copy link

avaer commented May 30, 2017

Thanks for this!

I think the code here is busted though. It's using local i j k but I think it should be using the instance vars _i _j _k.

The instance vars are what's actually used in the setting. Also those instance vars won't actually be set at all during construction so this will crash depending on your environment.

I think this would be fixed if we use _i and friends.

@weshoke
Copy link
Owner

weshoke commented May 30, 2017

You're right. Presumably this should be changed as well.

@shwilks
Copy link

shwilks commented Jan 12, 2021

Thanks also for this code! I've corrected the error discussed here, I notice there's no licence in this repo but it would be useful if it's ok with you to incorporate this code into an R package? I would want to make sure that's ok and that I get the code attribution right though, I found it in the first place because this same code is included in scikit for python: https://github.com/scikit-image/scikit-image/blob/master/skimage/measure/mc_meta/MarchingCubes.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants