You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think the code here is busted though. It's using local ijk but I think it should be using the instance vars _i_j_k.
The instance vars are what's actually used in the setting. Also those instance vars won't actually be set at all during construction so this will crash depending on your environment.
I think this would be fixed if we use _i and friends.
The text was updated successfully, but these errors were encountered:
Thanks also for this code! I've corrected the error discussed here, I notice there's no licence in this repo but it would be useful if it's ok with you to incorporate this code into an R package? I would want to make sure that's ok and that I get the code attribution right though, I found it in the first place because this same code is included in scikit for python: https://github.com/scikit-image/scikit-image/blob/master/skimage/measure/mc_meta/MarchingCubes.cpp
Thanks for this!
I think the code here is busted though. It's using local
i
j
k
but I think it should be using the instance vars_i
_j
_k
.The instance vars are what's actually used in the setting. Also those instance vars won't actually be set at all during construction so this will crash depending on your environment.
I think this would be fixed if we use
_i
and friends.The text was updated successfully, but these errors were encountered: