Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create LICENSE #267

Closed
wants to merge 5 commits into from
Closed

Create LICENSE #267

wants to merge 5 commits into from

Conversation

SwiftyProgrammer690
Copy link
Contributor

@SwiftyProgrammer690 SwiftyProgrammer690 commented Jun 11, 2022 •
edited
Loading

Fixes #261

@SwiftyProgrammer690 SwiftyProgrammer690 mentioned this pull request Jun 11, 2022
Open
styfle
styfle reviewed Jun 14, 2022
View reviewed changes
Copy link
Collaborator

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should probably be license.md if you have markdown contents.

@SwiftyProgrammer690
Copy link
Contributor Author

Fixed!

styfle
styfle reviewed Jun 14, 2022
View reviewed changes
LICENSE.md Outdated Show resolved Hide resolved
@SwiftyProgrammer690 @styfle
Update LICENSE.md
7120fd5 
Co-authored-by: Steven <[email protected]>
@SwiftyProgrammer690
Copy link
Contributor Author

Yeah

@SwiftyProgrammer690
Copy link
Contributor Author

Fixed that too

styfle
styfle reviewed Jun 14, 2022
View reviewed changes
LICENSE.md Outdated Show resolved Hide resolved
@SwiftyProgrammer690
Copy link
Contributor Author

Yes

styfle
styfle approved these changes Jun 14, 2022
View reviewed changes
Copy link
Collaborator

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

cc @wesbos for further review

@SwiftyProgrammer690
Copy link
Contributor Author

I think it is ready to be merged

@SwiftyProgrammer690
Copy link
Contributor Author

Looks good to me 👍

cc @wesbos for further review

Sure thing!

@SwiftyProgrammer690
Copy link
Contributor Author

I just did in gmail!

@SwiftyProgrammer690
Copy link
Contributor Author

I will probably just close this because of inactivity...

@SwiftyProgrammer690 SwiftyProgrammer690 deleted the patch-3 branch January 13, 2023 19:55
@SwiftyProgrammer690
Copy link
Contributor Author

this has been stale for a long time nowwwwww

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing LICENSE
2 participants
@SwiftyProgrammer690 @styfle