-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instructions? #32
Comments
Will do, I need to fix a few bugs before it is publicly used. Otherwise it could be a nightmare! Stay tuned! |
Looking forward to your improvements. |
+1 to this, looking forward to the instructions to try it out! Thanks @wentin for your work on this! |
+1 |
1 similar comment
+1 |
Interested as well. Any updates? |
+1 |
1 similar comment
+1 |
We didn't develop Underline.js, but here's a quick & dirty explanation on how we got this to work. Include Underline.js in your project. The code is: https://github.com/CloudflareApps/SmartUnderline/blob/master/js/smart-underline.js We minified that in our project, but whatever. Once that was included we just initialize it like so:
That turns it on with no options. There are plenty, but we liked it just the way it is. Hope that helps. Let us know if you need some more direction and we'll put something together and post a link here to a more in-depth instructional article. |
@jdmdigital Thank you for the explanation! I'd appreciate any links with more in-depth instructions whenever you get to that. Until then, quick question - how does |
@oyeanuj, Totally got that wrong. UnderlineJS is self-initializing. What we posted above is how to initialize SmartUnderline--which is what we chose to use in our project. Oops! Posted something about the two JS libraries, how they work, and what the differences are. Take a look here: https://jdmdigital.co/news/design/skip-descenders-javascript/ |
Could you be bothered to write some instructions on how to use this please?
Thanks
The text was updated successfully, but these errors were encountered: