Refactor

Author: yuanqing

packages/create-figma-plugin/src/create-figma-plugin-async.ts

@@ -1,10 +1,11 @@
 import { log } from '@create-figma-plugin/common'
 import fs from 'fs-extra'
-import { join, resolve } from 'path'
+import { join } from 'path'
 
-import { copyTemplateAsync } from './utilities/copy-template-async.js'
+import { copyPluginTemplateAsync } from './utilities/copy-plugin-template-async.js'
 import { installDependenciesAsync } from './utilities/install-dependencies-async.js'
 import { interpolateValuesIntoFilesAsync } from './utilities/interpolate-values-into-files-async.js'
+import { readPluginTemplateNamesAsync } from './utilities/read-template-names-async.js'
 import { resolveLatestStableVersions } from './utilities/resolve-latest-stable-versions.js'
 import { createDefaultSettings } from './utilities/settings/create-default-settings.js'
 import { promptForUserInputAsync } from './utilities/settings/prompt-for-user-input-async.js'
@@ -20,14 +21,11 @@ export async function createFigmaPluginAsync(options: {
       await throwIfDirectoryExistsAsync(join(process.cwd(), name))
     }
     if (typeof template !== 'undefined') {
-      const templateDirectory = resolve(
-        __dirname,
-        '..',
-        'plugin-templates',
-        template
-      )
-      if ((await fs.pathExists(templateDirectory)) === false) {
-        throw new Error(`Invalid template: ${template}`)
+      const templateNames = await readPluginTemplateNamesAsync()
+      if (templateNames.indexOf(template) === -1) {
+        throw new Error(
+          `Template must be one of "${templateNames.join('", "')}"`
+        )
       }
     }
     log.info('Scaffolding a new plugin...')
@@ -36,8 +34,8 @@ export async function createFigmaPluginAsync(options: {
       : await promptForUserInputAsync({ name, template })
     const pluginDirectoryPath = join(process.cwd(), settings.name)
     await throwIfDirectoryExistsAsync(pluginDirectoryPath)
-    log.info('Copying template...')
-    await copyTemplateAsync(pluginDirectoryPath, settings.template)
+    log.info(`Copying "${settings.template}" template...`)
+    await copyPluginTemplateAsync(pluginDirectoryPath, settings.template)
     const versions = await resolveLatestStableVersions()
     await interpolateValuesIntoFilesAsync(pluginDirectoryPath, {
       ...settings,

packages/create-figma-plugin/src/utilities/copy-template-async.ts renamed to packages/create-figma-plugin/src/utilities/copy-plugin-template-async.ts

@@ -4,7 +4,7 @@ import { fileURLToPath } from 'url'
 
 const __dirname = dirname(fileURLToPath(import.meta.url))
 
-export async function copyTemplateAsync(
+export async function copyPluginTemplateAsync(
   pluginDirectoryPath: string,
   template: string
 ): Promise<void> {

packages/create-figma-plugin/src/utilities/read-template-names-async.ts

@@ -0,0 +1,19 @@
+import globby from 'globby'
+import { dirname, resolve } from 'path'
+import { fileURLToPath } from 'url'
+
+const __dirname = dirname(fileURLToPath(import.meta.url))
+
+export async function readPluginTemplateNamesAsync(): Promise<Array<string>> {
+  const pluginTemplatesDirectory = resolve(
+    __dirname,
+    '..',
+    '..',
+    'plugin-templates'
+  )
+  const pluginTemplateNames = await globby('*', {
+    cwd: pluginTemplatesDirectory,
+    onlyDirectories: true
+  })
+  return pluginTemplateNames
+}

packages/create-figma-plugin/src/utilities/settings/prompt-for-user-input-async.ts

@@ -2,6 +2,7 @@ import { constants } from '@create-figma-plugin/common'
 import inquirer from 'inquirer'
 
 import { Settings } from '../../types/settings.js'
+import { readPluginTemplateNamesAsync } from '../read-template-names-async.js'
 import { createPluginDisplayName } from './create-plugin-display-name.js'
 
 export async function promptForUserInputAsync(options: {
@@ -37,7 +38,7 @@ export async function promptForUserInputAsync(options: {
     },
     typeof template === 'undefined'
       ? {
-          choices: [constants.defaultTemplate, 'ui'],
+          choices: await readPluginTemplateNamesAsync(),
           default: constants.defaultTemplate,
           filter,
           message: 'template',