Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pooling in Stores !? #91

Open
quarkus opened this issue Mar 7, 2023 · 3 comments
Open

Update Pooling in Stores !? #91

quarkus opened this issue Mar 7, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@quarkus
Copy link
Contributor

quarkus commented Mar 7, 2023

May be it makes sense to pool Updates in Stores just like we do in the Base Element.
Maybe this is not needed once we can have Store in Stores ..

@quarkus quarkus added enhancement New feature or request help wanted Extra attention is needed labels Mar 7, 2023
@quarkus quarkus self-assigned this Mar 7, 2023
@eddyloewen
Copy link
Contributor

I think it makes sense to also add the pooling for stores. The main reason to have the pooling was to reduce the number of updates/renders. If we now start moving properties and logic to stores - they will call the "requestUpdate" more often than before because it is not pooled.

@quarkus
Copy link
Contributor Author

quarkus commented Dec 1, 2023

but the updates are pooled in the elements anyways ;)

@eddyloewen
Copy link
Contributor

@quarkus not if the updates are comming from the same property. Pooling works across multiple properties on the element. The store is only one property on the element. When the store has multiple properties as well and those are not pooled (in the store) multiple changes inside the store will trigger mutliple upldates on the element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants