fix: a regression

Author: alexander-akait

.changeset/itchy-cycles-notice.md

@@ -0,0 +1,5 @@
+---
+"tapable": patch
+---
+
+Revert ignore invalid `before` values.

lib/Hook.js

@@ -152,13 +152,6 @@ class Hook {
 		} else if (Array.isArray(item.before)) {
 			before = new Set(item.before);
 		}
-		if (before) {
-			for (const name of before) {
-				if (!this.taps.some((tap) => tap.name === name)) {
-					before.delete(name);
-				}
-			}
-		}
 		let stage = 0;
 		if (typeof item.stage === "number") {
 			stage = item.stage;

lib/__tests__/Hook.js

@@ -108,7 +108,8 @@ describe("Hook", () => {
 		);
 	});
 
-	it("should ignore invalid before values", () => {
+	it("should not ignore invalid before values", () => {
+		// A plugin may use a hook that will never be executed
 		const hook = new SyncHook();
 
 		const calls = [];
@@ -126,7 +127,7 @@ describe("Hook", () => {
 		hook.tap(
 			{
 				name: "C",
-				before: [" "]
+				before: ["Y"]
 			},
 			() => calls.push("C")
 		);
@@ -149,6 +150,6 @@ describe("Hook", () => {
 
 		calls.length = 0;
 		hook.call();
-		expect(calls).toEqual(["A", "B", "C", "D", "E"]);
+		expect(calls).toEqual(["C", "B", "A", "D", "E"]);
 	});
 });