fix: quiet flag only prints when set to false (#60)

* refactor: pull out errorMessage constant

Author: JaKXz

index.js

@@ -15,8 +15,7 @@ function apply (options, compiler) {
   options = options || {};
   var context = options.context || compiler.context;
   options = assign({
-    formatter: formatter,
-    quiet: false
+    formatter: formatter
   }, options, {
     // Default Glob is any directory level of scss and/or sass file,
     // under webpack's context and specificity changed via globbing patterns

lib/constants.js

@@ -1,5 +1,6 @@
 'use strict';
 
 module.exports = {
-  defaultFilesGlob: '**/*.s?(c|a)ss'
+  defaultFilesGlob: '**/*.s?(c|a)ss',
+  errorMessage: 'Failed because of a stylelint error.\n'
 };

lib/run-compilation.js

@@ -2,6 +2,7 @@
 
 var chalk = require('chalk');
 var linter = require('./linter');
+var errorMessage = require('./constants').errorMessage;
 
 /**
  * Function bound to the plugin `apply` method to run the linter and report any
@@ -26,19 +27,19 @@ module.exports = function runCompilation (options, compiler, done) {
         return file.errored;
       });
 
-      if (!options.quiet) {
-        console.log(chalk.yellow(options.formatter(results)));
+      if (options.quiet === false) {
+        console.warn(options.formatter(results));
       }
 
       if (options.failOnError && errors.length) {
-        done(new Error('Failed because of a stylelint error.\n'));
+        done(new Error(errorMessage));
       } else {
         done();
       }
     })
     .catch(done);
 
-  compiler.plugin('after-emit', function onCompilation (compilation, callback) {
+  compiler.plugin('after-emit', function afterEmit (compilation, callback) {
     if (warnings.length) {
       compilation.warnings.push(chalk.yellow(options.formatter(warnings)));
       warnings = [];

test/index.test.js

@@ -1,12 +1,14 @@
 'use strict';
 
 var assign = require('object-assign');
+var td = require('testdouble');
 var StyleLintPlugin = require('../');
 var pack = require('./helpers/pack');
 var webpack = require('./helpers/webpack');
 var baseConfig = require('./helpers/base-config');
 
 var configFilePath = getPath('./.stylelintrc');
+var errorMessage = require('../lib/constants').errorMessage;
 
 describe('stylelint-webpack-plugin', function () {
   it('works with a simple file', function () {
@@ -51,7 +53,7 @@ describe('stylelint-webpack-plugin', function () {
     return pack(assign({}, baseConfig, config))
       .then(expect.fail)
       .catch(function (err) {
-        expect(err.message).to.equal('Failed because of a stylelint error.\n');
+        expect(err.message).to.equal(errorMessage);
       });
   });
 
@@ -82,26 +84,6 @@ describe('stylelint-webpack-plugin', function () {
       });
   });
 
-  // TODO use snapshots to ensure something is printed to the console
-  it.skip('sends messages to console when quiet prop set to false', function () {
-    var config = {
-      context: './test/fixtures/syntax-error',
-      entry: './index',
-      plugins: [
-        new StyleLintPlugin({
-          configFile: configFilePath,
-          quiet: true
-        })
-      ]
-    };
-
-    return pack(assign({}, baseConfig, config))
-      .then(function (stats) {
-        expect(stats.compilation.errors).to.have.length(1);
-        expect(stats.compilation.warnings).to.have.length(0);
-      });
-  });
-
   it('fails when .stylelintrc is not a proper format', function () {
     var config = {
       entry: './index',
@@ -121,6 +103,35 @@ describe('stylelint-webpack-plugin', function () {
       });
   });
 
+  context('iff quiet is strictly false', function () {
+    beforeEach(function () {
+      td.replace(console, 'warn', td.function());
+    });
+
+    afterEach(function () {
+      td.reset();
+    });
+
+    it('sends messages to the console', function () {
+      var config = {
+        context: './test/fixtures/syntax-error',
+        entry: './index',
+        plugins: [
+          new StyleLintPlugin({
+            configFile: configFilePath,
+            quiet: false
+          })
+        ]
+      };
+
+      return pack(assign({}, baseConfig, config))
+        .then(function (stats) {
+          expect(stats.compilation.errors).to.have.length(1);
+          td.verify(console.warn(td.matchers.contains('✖')));
+        });
+    });
+  });
+
   context('without StyleLintPlugin configuration', function () {
     var config = {
       context: './test/fixtures/lint-free',