Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose WebNN API to shared workers and service workers #823

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Expose WebNN API to shared workers and service workers #823

merged 1 commit into from
Feb 27, 2025
+7 −7

Conversation

inexorabletash
Copy link
Member

@inexorabletash inexorabletash commented Feb 24, 2025 •
edited by pr-preview bot
Loading

@inexorabletash
Copy link
Member Author

I'm working on the corresponding Chromium and WPT changes. Seems straightforward.

huningxin
huningxin approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@inexorabletash inexorabletash marked this pull request as draft February 25, 2025 00:20
@inexorabletash inexorabletash marked this pull request as ready for review February 26, 2025 22:36
@inexorabletash inexorabletash requested a review from fdwr February 26, 2025 22:36
@inexorabletash
Copy link
Member Author

@fdwr I think this is ready to go. The corresponding Chromium and WPT change is up for review at https://chromium-review.googlesource.com/c/chromium/src/+/6299847

fdwr
fdwr approved these changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵️‍♂️

@fdwr fdwr merged commit a65f61f into webmachinelearning:main Feb 27, 2025
2 checks passed
github-actions bot added a commit that referenced this pull request Feb 27, 2025
@inexorabletash @github-actions
Expose WebNN API to shared workers and service workers (#823)
233f889 
SHA: a65f61f
Reason: push, by fdwr

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@inexorabletash inexorabletash deleted the enable-in-sws branch February 27, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huningxin huningxin huningxin approved these changes

@fdwr fdwr fdwr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose WebNN API to service workers
3 participants
@inexorabletash @huningxin @fdwr