Use AllowSharedBufferSource for MLGraphBuilder.constant()
#790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huningxin
commented
Nov 16, 2024
|
@a-sully , PTAL? |
a-sully
reviewed
Nov 18, 2024
huningxin
commented
Nov 21, 2024
| @@ -1503,9 +1504,6 @@ Build a composed graph up to a given output operand into a computational graph a | |||
| 1. Set |graph|.{{MLGraph/[[context]]}} to [=this=].{{MLGraphBuilder/[[context]]}}. | |||
| 1. [=set/For each=] |operand| in |inputs|: | |||
| 1. Set |graph|.{{MLGraph/[[inputDescriptors]]}}[|operand|.{{MLOperand/[[name]]}}] to |operand|.{{MLOperand/[[descriptor]]}}. | |||
|
|
|||
| Issue(566): If {{MLGraphBuilder/constant(descriptor, bufferView)|constants'}} {{ArrayBuffer}}s are not [=ArrayBuffer/transferred=], make copies for [=MLGraphBuilder/graph=]'s [=computational graph/constants=] here. | |||
There was a problem hiding this comment.
Note: this issue is closed and not relevant.
huningxin
commented
Nov 21, 2024
index.bs
Outdated
| </summary> | ||
| 1. If [=this=].{{MLGraphBuilder/[[hasBuilt]]}} is true, then [=exception/throw=] an "{{InvalidStateError}}" {{DOMException}}. | ||
| 1. If [=MLOperandDescriptor/checking dimensions=] given |descriptor| returns false, then [=exception/throw=] a {{TypeError}}. | ||
| 1. If [=validating buffer with descriptor=] given |bufferView| and |descriptor| returns false, then [=exception/throw=] a {{TypeError}}. | ||
| 1. If [=validating buffer with descriptor=] given |bufferSource| and |descriptor| returns false, then [=exception/throw=] a {{TypeError}}. |
There was a problem hiding this comment.
Note: This depends on #787 for supporting AllowSharedBufferSource in "validate buffer with descriptor" algorithm.
huningxin
changed the title
MLGraphBuilder.constant()AllowSharedBufferSource for MLGraphBuilder.constant()
a-sully
reviewed
Nov 21, 2024
|
@fdwr , PTAL? /cc @inexorabletash |
There was a problem hiding this comment.
Overall LGTM, but +1 to a naming suggestion.
After this and #787 go in, probably when compute() is removed, we should review any lingering ArrayBufferView references in the spec and update them as appropriate (to be AllowSharedBufferSource, replace with MLTensor, reword entirely, etc)
fdwr
approved these changes
Nov 27, 2024
index.bs
Outdated
| </summary> | ||
| 1. If [=this=].{{MLGraphBuilder/[[hasBuilt]]}} is true, then [=exception/throw=] an "{{InvalidStateError}}" {{DOMException}}. | ||
| 1. If [=MLOperandDescriptor/checking dimensions=] given |descriptor| returns false, then [=exception/throw=] a {{TypeError}}. | ||
| 1. If [=validating buffer with descriptor=] given |bufferView| and |descriptor| returns false, then [=exception/throw=] a {{TypeError}}. | ||
| 1. If [=validating buffer with descriptor=] given |bufferSource| and |descriptor| returns false, then [=exception/throw=] a {{TypeError}}. |
fdwr
approved these changes
Nov 27, 2024
|
Thanks for the review and approval. I am going to merge it. |
github-actions bot
added a commit
that referenced
this pull request
Nov 28, 2024
SHA: bcc5dc2 Reason: push, by huningxin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 2, 2024
This CL implements the WebNN spec change proposal [1] that uses `AllowSharedBufferSource` for `MLGraphBuilder.constant()`. [1]: webmachinelearning/webnn#790 Bug: 380896836 Change-Id: Ib8fc58daaabf7493b08f9634daa1eeb08a50ad35 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 3, 2024
This CL implements the WebNN spec change proposal [1] that uses `AllowSharedBufferSource` for `MLGraphBuilder.constant()`. [1]: webmachinelearning/webnn#790 Bug: 380896836 Change-Id: Ib8fc58daaabf7493b08f9634daa1eeb08a50ad35 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Dec 3, 2024
This CL implements the WebNN spec change proposal [1] that uses `AllowSharedBufferSource` for `MLGraphBuilder.constant()`. [1]: webmachinelearning/webnn#790 Bug: 380896836 Change-Id: Ib8fc58daaabf7493b08f9634daa1eeb08a50ad35 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6050722 Reviewed-by: Austin Sullivan <[email protected]> Reviewed-by: Weizhong Xia <[email protected]> Commit-Queue: ningxin hu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1390750}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 3, 2024
This CL implements the WebNN spec change proposal [1] that uses `AllowSharedBufferSource` for `MLGraphBuilder.constant()`. [1]: webmachinelearning/webnn#790 Bug: 380896836 Change-Id: Ib8fc58daaabf7493b08f9634daa1eeb08a50ad35 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6050722 Reviewed-by: Austin Sullivan <[email protected]> Reviewed-by: Weizhong Xia <[email protected]> Commit-Queue: ningxin hu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1390750}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 3, 2024
This CL implements the WebNN spec change proposal [1] that uses `AllowSharedBufferSource` for `MLGraphBuilder.constant()`. [1]: webmachinelearning/webnn#790 Bug: 380896836 Change-Id: Ib8fc58daaabf7493b08f9634daa1eeb08a50ad35 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6050722 Reviewed-by: Austin Sullivan <[email protected]> Reviewed-by: Weizhong Xia <[email protected]> Commit-Queue: ningxin hu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1390750}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 5, 2024
… for constant, a=testonly Automatic update from web-platform-tests WebNN: Support `AllowSharedBufferSource` for constant This CL implements the WebNN spec change proposal [1] that uses `AllowSharedBufferSource` for `MLGraphBuilder.constant()`. [1]: webmachinelearning/webnn#790 Bug: 380896836 Change-Id: Ib8fc58daaabf7493b08f9634daa1eeb08a50ad35 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6050722 Reviewed-by: Austin Sullivan <[email protected]> Reviewed-by: Weizhong Xia <[email protected]> Commit-Queue: ningxin hu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1390750} -- wpt-commits: 2643d924a518d89e3a8239ef92705bf1373504c9 wpt-pr: 49470
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Dec 6, 2024
… for constant, a=testonly Automatic update from web-platform-tests WebNN: Support `AllowSharedBufferSource` for constant This CL implements the WebNN spec change proposal [1] that uses `AllowSharedBufferSource` for `MLGraphBuilder.constant()`. [1]: webmachinelearning/webnn#790 Bug: 380896836 Change-Id: Ib8fc58daaabf7493b08f9634daa1eeb08a50ad35 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6050722 Reviewed-by: Austin Sullivan <[email protected]> Reviewed-by: Weizhong Xia <[email protected]> Commit-Queue: ningxin hu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1390750} -- wpt-commits: 2643d924a518d89e3a8239ef92705bf1373504c9 wpt-pr: 49470
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Dec 13, 2024
… for constant, a=testonly Automatic update from web-platform-tests WebNN: Support `AllowSharedBufferSource` for constant This CL implements the WebNN spec change proposal [1] that uses `AllowSharedBufferSource` for `MLGraphBuilder.constant()`. [1]: webmachinelearning/webnn#790 Bug: 380896836 Change-Id: Ib8fc58daaabf7493b08f9634daa1eeb08a50ad35 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6050722 Reviewed-by: Austin Sullivan <asullychromium.org> Reviewed-by: Weizhong Xia <weizhonggoogle.com> Commit-Queue: ningxin hu <ningxin.huintel.com> Cr-Commit-Position: refs/heads/main{#1390750} -- wpt-commits: 2643d924a518d89e3a8239ef92705bf1373504c9 wpt-pr: 49470 UltraBlame original commit: 25acfa3eb6954786eb5663d66876762a2a82eec9
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Dec 13, 2024
… for constant, a=testonly Automatic update from web-platform-tests WebNN: Support `AllowSharedBufferSource` for constant This CL implements the WebNN spec change proposal [1] that uses `AllowSharedBufferSource` for `MLGraphBuilder.constant()`. [1]: webmachinelearning/webnn#790 Bug: 380896836 Change-Id: Ib8fc58daaabf7493b08f9634daa1eeb08a50ad35 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6050722 Reviewed-by: Austin Sullivan <asullychromium.org> Reviewed-by: Weizhong Xia <weizhonggoogle.com> Commit-Queue: ningxin hu <ningxin.huintel.com> Cr-Commit-Position: refs/heads/main{#1390750} -- wpt-commits: 2643d924a518d89e3a8239ef92705bf1373504c9 wpt-pr: 49470 UltraBlame original commit: 25acfa3eb6954786eb5663d66876762a2a82eec9
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Dec 13, 2024
… for constant, a=testonly Automatic update from web-platform-tests WebNN: Support `AllowSharedBufferSource` for constant This CL implements the WebNN spec change proposal [1] that uses `AllowSharedBufferSource` for `MLGraphBuilder.constant()`. [1]: webmachinelearning/webnn#790 Bug: 380896836 Change-Id: Ib8fc58daaabf7493b08f9634daa1eeb08a50ad35 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6050722 Reviewed-by: Austin Sullivan <asullychromium.org> Reviewed-by: Weizhong Xia <weizhonggoogle.com> Commit-Queue: ningxin hu <ningxin.huintel.com> Cr-Commit-Position: refs/heads/main{#1390750} -- wpt-commits: 2643d924a518d89e3a8239ef92705bf1373504c9 wpt-pr: 49470 UltraBlame original commit: 25acfa3eb6954786eb5663d66876762a2a82eec9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #788
Preview | Diff